Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add origin method to Dom_html.location #415

Closed
wants to merge 3 commits into from
Closed

Conversation

zoggy
Copy link
Contributor

@zoggy zoggy commented Feb 1, 2016

No description provided.

@hhugo
Copy link
Member

hhugo commented Feb 1, 2016

It seems this property doesn't have good support on IE. Can you make it Optdef.t instead ? and eventually provide an helpers function along the line of http://tosbourn.com/a-fix-for-window-location-origin-in-internet-explorer/.
Thanks

@zoggy
Copy link
Contributor Author

zoggy commented Feb 1, 2016

Ok for the Optdef.t and I will add an origin_safe method too.

This function does not use location##origin, since the result may vary
from one browser to another: http://www.w3schools.com/jsref/prop_loc_origin.asp
@hhugo
Copy link
Member

hhugo commented Mar 27, 2016

Manually merged with small update/fix.
location_origin_safe has been rename into location_origin.
Thanks

@hhugo hhugo closed this Mar 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants