Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lwt.preemptive an alias for lwt.unix; remove it in 4.0.0 #487

Closed
aantron opened this issue Oct 20, 2017 · 1 comment
Closed

Make lwt.preemptive an alias for lwt.unix; remove it in 4.0.0 #487

aantron opened this issue Oct 20, 2017 · 1 comment
Labels
Milestone

Comments

@aantron
Copy link
Collaborator

aantron commented Oct 20, 2017

This is more of a long-term plan: there's no purpose in factoring out a separate lwt_preemptive. It should just be part of lwt_unix.

The reasoning is that, I think, these days, any platform lwt.unix compiles on is also going to have native threads support in the OCaml distribution, so we can assume -threads, so there is no purpose in separating lwt.preemptive.

If this is not true, or any other assumptions I'm making are wrong, please let me know. Also, please cc anyone that might have more information, including about the more obscure systems OCaml supports.

@aantron aantron added this to the 3.2.0 milestone Nov 7, 2017
@aantron aantron changed the title Make lwt.preemptive an alias for lwt.unix Make lwt.preemptive an alias for lwt.unix; remove it in 4.0.0 Nov 7, 2017
@aantron
Copy link
Collaborator Author

aantron commented Nov 7, 2017

...and I intend to remove it as a separate package in 4.0.0. Please voice any objections.

aantron added a commit that referenced this issue Nov 10, 2017
@aantron aantron modified the milestones: 3.2.0, 4.0.0 Nov 10, 2017
aantron added a commit that referenced this issue Nov 10, 2017
aantron added a commit that referenced this issue Dec 24, 2017
This is part of merging lwt.preemptive into lwt.unix without breaking
downstream packages. See

  ocaml/opam-repository#11071 (comment)

See also #487.
pveber added a commit to pveber/bistro that referenced this issue Apr 10, 2018
pveber added a commit to biocaml/biocaml that referenced this issue Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant