Better custom configuration #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongchangwu
force-pushed
the
configure
branch
2 times, most recently
from
b4c9fb6
to
acaf44b
Compare
I was tripped up by the example in the travis script when trying to build lwt with libev without opam. `dune exec src/unix/configurator.exe -- -use-libev true` doesn't really do anything since the `lwt_config` file will be generated at the project root instead of where dune expects it. Also update the `dune` file to allow proper fallback. Currently dune gives a warning when a file is both in the source tree and generated by a rule. This will be an error in future versions of dune.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tripped up by the example in the travis script when trying to
build lwt with libev without opam.
dune exec src/unix/configurator.exe -- -use-libev truedoesn't reallydo anything since the
lwt_configfile will be generated at the project rootinstead of where dune expects it.
Also update the
dunefile to allow proper fallback. Currently dunegives a warning when a file is both in the source tree and generated by a rule.
This will be an error in future versions of dune.