Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang in test suite on 4.4.0 beta2: "'.../@ftp/dir.m' has been modified by another application" #69

Open
apjanke opened this issue Jun 23, 2018 · 14 comments
Assignees
Labels

Comments

@apjanke
Copy link
Contributor

@apjanke apjanke commented Jun 23, 2018

A long way in to running the test suite in the GUI, it switches to the editor and pops up this dialog. The dialog is unresponsive, so this effectively hangs Octave.

screen shot 2018-06-23 at 4 42 20 am

This is with the Ghostscript fix and the Qt patch to remove FSEventStreamFlushSync() applied.

The files dir.m, set.m, quantile.m, and ls.m are open in the editor when this happened. I didn't start out with any files open in the editor.

@apjanke apjanke self-assigned this Jun 23, 2018
@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Jun 23, 2018

I got around this by watching for the editor to pop up, and then manually closing all the files it had open, while the test suite was still running. Ugly hack, but it got me through the test suite so I could see what was still failing.

@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Jun 23, 2018

The dialog hang might be a transient issue. I ran the test suite in the GUI again, with no significant changes, and kept my hands off it, leaving those files up. The dialog didn't appear. Ran __run_test_suite__ a second time in that GUI session without closing any files in the editor, and I got the dialog hang.

Exited, ran a new session, and got the dialog hang on the first run of __run_test_suite__.

screen shot 2018-06-23 at 1 55 01 pm

The file "ftp.m" is the leftmost tab in the list of files in the editor. There may not be anything special about that file aside from the fact that it's open and first in the list; maybe all the files in the editor are hitting conditions where they are seen as "modified", and ftp.m is just the first one Octave mentions.

When the hang happens, Activity Monitor shows no significant CPU being used by octave-gui, so the test suite is not proceeding.

I've also rerun the test suite and gotten the dialog but not had it be unresponsive, so it doesn't actually hang; you can hit "No" and continue. When this happens, it's only the one dialog about ftp.m, no additional dialogs about the other open files.

@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Jun 23, 2018

Aha! I got the hang running an Octave.app built against the regular, non-patched Qt. Which means maybe we can use our patch after all without introducing additional errors.

In this one, I had the Editor window undocked (something I had done in a previous session), and it hung only the Editor window; the Command Window proceeded to finish the tests, and remained responsive.

@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Jun 24, 2018

I'm not going to close this yet, but I think this is just a bug in the upstream Qt GUI, so it's not a blocker for the release of Octave.app 4.4.0.

@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Jun 24, 2018

Since I've run in to this a few times with non-patched Qt, I'm okay with saying this is not Octave.app-specific, and not a blocker for the 4.4.0 release. Changing this to low priority. Will report upstream.

@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Jun 24, 2018

@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Jun 24, 2018

The editor window initially pops up right around here in the test suite.


  libinterp/corefcn/colloc.cc-tst ............................. PASS     12/12
  libinterp/corefcn/conv2.cc-tst .............................. PASS     48/51
                                                   (reported bug) XFAIL   3
  libinterp/corefcn/dassl.cc-tst .............................. PASS      4/4
  libinterp/corefcn/data.cc-tst ............................... PASS   1080/1086
                                                   (reported bug) XFAIL   6
  libinterp/corefcn/debug.cc-tst .............................. PASS      1/1
  libinterp/corefcn/defaults.cc-tst ........................... PASS      6/6
  libinterp/corefcn/det.cc-tst ................................ PASS      6/6
  libinterp/corefcn/dirfns.cc-tst ............................. PASS      1/1
  libinterp/corefcn/dlmread.cc-tst ............................ PASS      2/4
                                             (run-time condition) SKIP    2
                                                   (reported bug) XFAIL   2
  libinterp/corefcn/dot.cc-tst ................................ PASS     22/22

If you close it manually, it pops back up a couple times later on in the test suite.

@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Jun 25, 2018

Related upstream bug, for the opening of the files in the editor in the first place: https://savannah.gnu.org/bugs/?49119

@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Jun 25, 2018

As a workaround, if you just undock the Editor window in your session and leave it that way, then only the Editor window will hang, and the main Octave GUI and Command Window will keep going and stay responsive.

@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Jun 25, 2018

Another workaround: under Settings > Editor, enable "Reload externally changed files without prompt". No hangs under this setting!

Per https://savannah.gnu.org/bugs/index.php?54173#comment4.

@schoeps
Copy link

@schoeps schoeps commented Jun 27, 2018

I'd say that this bug should not stop us from a release. It's known upstream and it probably affects no user (running the tests manually is not a common thing).

@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Jun 27, 2018

I agree.

Moving the milestone for this to "The Future" to indicate it's not a blocker for 4.4.0.

@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Dec 5, 2018

The hang no longer happens for me with Octave 4.4.1. Looks like it was fixed upstream.

Closing as fixed.

@apjanke apjanke closed this Dec 5, 2018
@apjanke
Copy link
Contributor Author

@apjanke apjanke commented Jan 20, 2019

The hang is back in 4.4.1. Reopening.

@apjanke apjanke reopened this Jan 20, 2019
@apjanke apjanke transferred this issue from octave-app/octave-app-bundler Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.