Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

absolute_action_mask removed #100

Open
andrearosasco opened this issue May 27, 2024 · 4 comments
Open

absolute_action_mask removed #100

andrearosasco opened this issue May 27, 2024 · 4 comments

Comments

@andrearosasco
Copy link
Contributor

Hello,
I noticed that the new commits removed the absolute_action_mask argument.
I was wondering how is action padding being managed now?

Thanks

@zwbx
Copy link

zwbx commented May 28, 2024

Hey, I encountered the same problem, have you successfully ran any scripts of the new committed version

@Anatr1
Copy link

Anatr1 commented Jun 6, 2024

I was wandering the same. Any update?

@raffaello-camoriano
Copy link

We are also encountering blocking issues with this. Any additional detail regarding action padding would be really helpful. Thank you.

@HomerW
Copy link
Collaborator

HomerW commented Jun 7, 2024

Hi, sorry the late reply! Previously, the absolute_action_mask was used to figure out what to do with actions in a chunk that go past the point where the goal was achieved (either zero-ing them out or duplicating the last action so that the policy is trained to remain at the goal). Now, instead of using absolute_action_mask and trying to create neutral actions, the dataloader simply indicates when the goal (or the end of the trajectory, in case of no goals) has been reached using the key task_completed. It also updates action_pad_mask to indicate that any actions past the end of the goal should be considered padding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants