Relation Manager Customisation Improvements

[danharrin]

This change allows for easy customisation of the relation manager titles and toolbar buttons.

For buttons - define your custom strings directly in the standard toolbarButtons syntax...

toolbarButtons:
    create: acme.blog::lang.subcategory.CreateButtonText
    delete: # omit the string to fall back to the default button text

...and the old syntax still works...

toolbarButtons: create|delete

For titles - define different strings for each mode (form, list or pivot)...

title:
    form: acme.blog::lang.subcategory.FormTitle
    list: acme.blog::lang.subcategory.ListTitle

This feature provides developer convenience, for example in this situation where I have a relation manager that is used to assign user permissions to a project:
Before

After

This PR contains no breaking changes.

[bennothommo]

@danharrin I noticed in the changes that you've cleared out a fair few blank lines between lines 886 and 1000 of modules/backend/behaviors/RelationController.php. Whilst some of those could be removed to appease the code quality tests, some of them were probably being used for spacing. Would you be able to reinstate those, and fix the issues reported here: https://travis-ci.org/octobercms/october/jobs/556694232#L790

[danharrin]

Hi @bennothommo, seems that VS Code played up and went mental with the new lines - my bad for not checking. Fixed the newline issues brought up by Travis CI, however some other errors have popped up now that look seemingly unrelated to this PR, mind having a look through them?

[bennothommo]

@danharrin The code quality checks basically are limited to checking complete files - we can't limit it to specifically the lines of code that you have modified, so it's possible that it will bring up issues in parts of the code that have been there for while.

Given that it is only one minor issue - this empty line here needs to be removed - would you mind just quickly removing that for us and then we'll get cracking with the testing?

[danharrin]

All done @bennothommo 👍

[bennothommo]

Cheers @danharrin. Just note this won't be out until we start development on build 458, as 457 is in feature freeze now.

[danharrin]

No worries @bennothommo :)

[danharrin]

All whitespace has been removed @LukeTowers

[danharrin]

All done @LukeTowers.

[danharrin]

Those changes should be complete @LukeTowers 👍

[LukeTowers]

LGTM! Waiting on @bennothommo to review again.

[LukeTowers]

@danharrin is there a PR to the docs documenting the new functionality?

[danharrin]

Not yet, is that something that needs doing before this can be merged? We could just prepare something before it's released into a version.

[LukeTowers]

@danharrin yup, needs to be ready to go before it gets merged otherwise it'll never get done. Speaking from experience here 😂

[bennothommo]

Sorry @danharrin, just a couple more :)

[danharrin]

All done @bennothommo.

@LukeTowers, I've done the docs change, see octobercms/docs#444.