Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we turn off the "Get more info for this Issue" prompt #1133

Closed
gep13 opened this issue Oct 19, 2018 · 4 comments
Closed

Can we turn off the "Get more info for this Issue" prompt #1133

gep13 opened this issue Oct 19, 2018 · 4 comments
Labels
octobox.io Issue reported for Octobox.io question Support and discussion of existing and new functionality

Comments

@gep13
Copy link

gep13 commented Oct 19, 2018

💥 Proposal

What feature you'd like to see

I would like the ability to turn off the reminder/prompt to install the GitHub application:

image

Motivation

I have already installed the GitHub App for all the repositories that I can, as there are some that I am not able to. I don't need reminded about the GitHub Application, as I am already using, and loving it.

Pitch

Simply put, it is a little bit annoying to see the reminder/prompt, when I already have it installed, and running, on other repositories.

@andrew andrew added enhancement Improvements and features octobox.io Issue reported for Octobox.io labels Oct 19, 2018
@hakusaro
Copy link

Not only that, but it's worth killing off the "install the app" banner in the user bar too.

@hakusaro
Copy link

I sent a wip pr for this issue in #1136. If I've gone in the right direction I'll add some tests and see if I can get this upstreamed rapidly. :)

@andrew andrew self-assigned this Oct 22, 2018
@andrew
Copy link
Member

andrew commented Oct 30, 2018

I'd prefer to avoid adding more check boxes to the settings page.

I think we also need to take a different approach to solving #1133, just turning off all prompts doesn't really work to help get Octobox.io to become a sustainable open source project, which the GitHub app will be the main source of income.

The way I'd like to change the behavior of the popup would be to turn it from hover to click if the user has installed the GitHub app on any one or more repository that they have access to.

@andrew andrew added question Support and discussion of existing and new functionality and removed enhancement Improvements and features labels Oct 30, 2018
@andrew
Copy link
Member

andrew commented Nov 5, 2018

#1183 will hide the message in the header once a user has authorized the GitHub app, even if they haven't installed it on any of their repos

@BenJam BenJam closed this as completed Nov 12, 2018
@andrew andrew removed their assignment Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
octobox.io Issue reported for Octobox.io question Support and discussion of existing and new functionality
Projects
None yet
Development

No branches or pull requests

4 participants