Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snooze notifications #1858

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@andrew
Copy link
Member

commented May 27, 2019

Bringing some of #1054, finishing it off and adding support for thread view, closes #452.

Current snoozing options are:

  • 1 hour
  • 1 day
  • 1 week
  • 1 month

Other options welcome, keeping in mind that timezones are a thing so I'd like to stick to relative time's for the initial ship to keep things simple.

Todo:

  • One bug to fix with snoozing individual notifications
  • Show snoozed time in thread header

Screenshots:

Screenshot 2019-05-27 at 22 10 15

Screenshot 2019-05-27 at 22 09 59

Screenshot 2019-05-27 at 22 10 19

Screenshot 2019-05-27 at 22 10 09

@andrew andrew force-pushed the snooze branch from cf6a33b to c4bca2f May 27, 2019

@andrew andrew requested a review from BenJam May 27, 2019

@andrew andrew added the enhancement label May 27, 2019

@andrew andrew referenced this pull request May 27, 2019

Open

Snoozing notifications #452

@choldgraf

This comment has been minimized.

Copy link

commented May 27, 2019

This would be a really nice feature :-)

In my experience, there's value in at least one amount of time in-between "1 day" and "1 week". E.g., usually if there's a PR open in a project I'll say "I like this, I'll merge it after a few days unless somebody else suggests we should wait". In moments like that I've often wished I could snooze the PR in Octobox so that it pops into my feed later on (it'd be even better if I could tag the issue w/ something like "merge")

my 2 cents!

@jni

This comment has been minimized.

Copy link

commented May 28, 2019

Three options that I found useful in Mailbox:

  • Snooze until next week (ie always Monday regardless of what day today is)
  • Snooze until [date/time] (you could have a pop-up calendar widget when that is clicked) (imho this is a must-have, since all other things can be implemented from this)
  • (on mobile only) Snooze to desktop (ie disappears from the mobile view but reappears once you're on your computer)
@bitboxer

This comment has been minimized.

Copy link

commented May 28, 2019

Snooze till Monday morning would be nice if i am reading issues and see something work related on a weekend.

@BenJam

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

keeping in mind that timezones are a thing so I'd like to stick to relative time's for the initial ship to keep things simple.

++

@BenJam
Copy link
Contributor

left a comment

LGTM, one minor thing: notifications in snoozed are doing the jigglydance on hover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.