Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrites the ca tests to use the dispatcher and custom fetch #584

Closed
wants to merge 31 commits into from

Conversation

nickfloyd
Copy link
Contributor

RE: #563

Now that we have introduced the changes for removing agent from octokit.request we needed to rework some tests to use the new patterns.


Behavior

Before the change?

  • The CA tests were skipped

After the change?

  • They have now been rewritten to use a dispatcher and custom fetch

wolfy1339 and others added 30 commits May 21, 2023 18:49
* build(package): set minimal node version in engines field to v18
* build: update esbuild options to use Node 18
BREAKING CHANGE: Drop support for NodeJS v14, v16
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
It isn't needed for oauth-user authentication
@nickfloyd nickfloyd added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 10, 2023
@ghost ghost added this to Maintenance in JS Jul 10, 2023
@nickfloyd
Copy link
Contributor Author

Closing in favor of branching from main now that the breaking change branch has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
JS
  
Maintenance
Development

Successfully merging this pull request may close these issues.

None yet

4 participants