Skip to content
This repository has been archived by the owner on Jun 20, 2022. It is now read-only.

Add Followers API #89

Merged
merged 10 commits into from
Mar 20, 2015
Merged

Add Followers API #89

merged 10 commits into from
Mar 20, 2015

Conversation

obsc
Copy link
Contributor

@obsc obsc commented Mar 9, 2015

@pengwynn

Added functionality for https://developer.github.com/v3/users/followers/
Also added booleans as an additional return just as we discussed.

@pengwynn
Copy link
Collaborator

pengwynn commented Mar 9, 2015

@obsc I dig the boolean returns. How would you feel about updating it to match the new approach we're pioneering over in #85 where each method takes a hyperlink instead of having a field on the service?

@obsc
Copy link
Contributor Author

obsc commented Mar 10, 2015

@pengwynn Refactored to the new approach in #85.

One issue that might need addressing is

if err != nil {
    return nil, &Result{Err: err}
}

is never called upon testing atm. Should I add failure tests that try to expand a broken hyperlink to hit 100% test coverage?

@pengwynn
Copy link
Collaborator

Should I add failure tests that try to expand a broken hyperlink to hit 100% test coverage?

That sounds awesome and would make @dannysperling really happy.

@obsc
Copy link
Contributor Author

obsc commented Mar 10, 2015

@pengwynn Fixed tests to include a failure test now.

pengwynn added a commit that referenced this pull request Mar 20, 2015
@pengwynn pengwynn merged commit 289a55b into master Mar 20, 2015
@pengwynn pengwynn deleted the followers branch March 20, 2015 21:08
@pengwynn
Copy link
Collaborator

✨ Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants