cleanup some mentions of master branch in codebase (#2306)

Octokit/Helpers/ReferenceExtensions.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Globalization;
+using System.Linq;
 using System.Threading.Tasks;
 
 namespace Octokit.Helpers
@@ -40,6 +41,7 @@ public static async Task<Reference> CreateBranch(this IReferencesClient referenc
         /// <param name="owner">The owner of the repository.</param>
         /// <param name="name">The name of the repository.</param>
         /// <param name="branchName">The new branch name</param>
+        [Obsolete("This function is hard-coded to master branch, which is no longer a valid assumption for the base branch. Instead of making a second request to figure out the default branch, this extension method will be removed in a future release. Please check the default branch on the repository and use a different overload")]
         public static async Task<Reference> CreateBranch(this IReferencesClient referencesClient, string owner, string name, string branchName)
         {
             Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));

README.md

@@ -1,15 +1,15 @@
-# Octokit - GitHub API Client Library for .NET 
+# Octokit - GitHub API Client Library for .NET
 
 ![Build status](https://github.com/octokit/octokit.net/workflows/CI%20Build/badge.svg)
-[![Build status](https://ci.appveyor.com/api/projects/status/cego2g42yw26th26/branch/master?svg=true)](https://ci.appveyor.com/project/github-windows/octokit-net/branch/master)
-[![codecov](https://codecov.io/gh/octokit/octokit.net/branch/master/graph/badge.svg)](https://codecov.io/gh/octokit/octokit.net)
+[![Build status](https://ci.appveyor.com/api/projects/status/cego2g42yw26th26/branch/main?svg=true)](https://ci.appveyor.com/project/github-windows/octokit-net/branch/main)
+[![codecov](https://codecov.io/gh/octokit/octokit.net/branch/main/graph/badge.svg)](https://codecov.io/gh/octokit/octokit.net)
 [![Join the chat at https://gitter.im/octokit/octokit.net](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/octokit/octokit.net?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![NuGet](http://img.shields.io/nuget/v/Octokit.svg)](https://www.nuget.org/packages/Octokit)
 [![NuGet](http://img.shields.io/nuget/v/Octokit.Reactive.svg)](https://www.nuget.org/packages/Octokit.Reactive)
 
 ![logo](octokit-dotnet_2.png)
 
-Octokit is a client library targeting .NET Framework 4.6 or greater and .NET Standard 2.0 
+Octokit is a client library targeting .NET Framework 4.6 or greater and .NET Standard 2.0
 and above that provides an easy way to interact with the
 [GitHub API](http://developer.github.com/v3/).
 
@@ -57,7 +57,7 @@ Documentation is available at http://octokitnet.readthedocs.io/en/latest/.
 
 Octokit is a single assembly designed to be easy to deploy anywhere.
 
-To clone and build it locally click the "Clone in Desktop" button above or run the 
+To clone and build it locally click the "Clone in Desktop" button above or run the
 following git commands.
 
 ```
@@ -97,7 +97,7 @@ problem.
 
 ## Related Projects
 
- - [ScriptCs.OctoKit](https://github.com/hnrkndrssn/ScriptCs.OctoKit) - a [script pack](https://github.com/scriptcs/scriptcs/wiki/Script-Packs) to use Octokit in scriptcs 
+ - [ScriptCs.OctoKit](https://github.com/hnrkndrssn/ScriptCs.OctoKit) - a [script pack](https://github.com/scriptcs/scriptcs/wiki/Script-Packs) to use Octokit in scriptcs
  - [ScriptCs.OctokitLibrary](https://github.com/ryanrousseau/ScriptCs.OctokitLibrary) - a [script library](https://github.com/scriptcs/scriptcs/wiki/Script-Libraries) to use Octokit in scriptcs
 
 ## Copyright and License

ReleaseNotes.md

@@ -253,9 +253,9 @@ Response Models
 
 - Octokit.net has been ported to dotnetcore :tada: providing libraries targetting `netstandard1.1` and `net45` frameworks
 
-- `Enum` fields in Octokit response classes are now wrapped in an `StringEnum<TEnum>` helper class, to provide more robustness in dealing with unknown API values for these fields.  Whilst the changes are backwards compatible, please consult the guidance on [working with Enums](https://github.com/octokit/octokit.net/blob/master/docs/working-with-enums.md) for more information
+- `Enum` fields in Octokit response classes are now wrapped in an `StringEnum<TEnum>` helper class, to provide more robustness in dealing with unknown API values for these fields.  Whilst the changes are backwards compatible, please consult the guidance on [working with Enums](https://github.com/octokit/octokit.net/blob/main/docs/working-with-enums.md) for more information
 
-- `IncludeAdmins` field is no longer present in `BranchProtectionRequiredStatusChecks` and `BranchProtectionRequiredStatusChecksUpdate` classes, instead use the new `EnforceAdmins` field on `BranchProtectionSettingsUpdate` or the [new explicit methods](https://github.com/octokit/octokit.net/blob/master/Octokit/Clients/IRepositoryBranchesClient.cs#L304-L365) for configuring Admin Enforcement on protected branches.  This was an [upstream API breaking change](https://developer.github.com/changes/2017-05-02-adoption-of-admin-enforced/) so we couldn't follow our normal deprecation schedule
+- `IncludeAdmins` field is no longer present in `BranchProtectionRequiredStatusChecks` and `BranchProtectionRequiredStatusChecksUpdate` classes, instead use the new `EnforceAdmins` field on `BranchProtectionSettingsUpdate` or the [new explicit methods](https://github.com/octokit/octokit.net/blob/main/Octokit/Clients/IRepositoryBranchesClient.cs#L304-L365) for configuring Admin Enforcement on protected branches.  This was an [upstream API breaking change](https://developer.github.com/changes/2017-05-02-adoption-of-admin-enforced/) so we couldn't follow our normal deprecation schedule
 
 ## Release Notes
 
@@ -350,18 +350,18 @@ Response Models
 
 **Breaking Changes**
 
- - Creating and Editing Issues (and PullRequests) using `NewIssue` and `IssueUpdate` requests 
-should now use the `Assignees` collection rather than the now deprecated 'Assignee` field. 
-Both fields can't be specified on the same request, so any code still using `Assignee` will 
+ - Creating and Editing Issues (and PullRequests) using `NewIssue` and `IssueUpdate` requests
+should now use the `Assignees` collection rather than the now deprecated 'Assignee` field.
+Both fields can't be specified on the same request, so any code still using `Assignee` will
 need to explicitly set `Assignees` to `null` to avoid Api validation errors.
 
- - `OrganizationsClient.GetAll(string user)` has been marked obsolete in favour of 
+ - `OrganizationsClient.GetAll(string user)` has been marked obsolete in favour of
 `OrganizationsClient.GetAllForUser(string user)`
 
  - `PullRequest.Comment` has been marked obsolete in favour of `PullRequest.ReviewComment`
 
-- Several `EventsClient` methods previously returned the incorrect `Activity` response class. 
-This has been corrected to `IssueEvent` which although is now correct could break calling 
+- Several `EventsClient` methods previously returned the incorrect `Activity` response class.
+This has been corrected to `IssueEvent` which although is now correct could break calling
 code that was written assuming this previous incorrect return type.
 
 ### New in 0.23.0 (released 07/10/2016)
@@ -413,21 +413,21 @@ you want to change the merge behaviour when merging a pull request.
 
 **Breaking Changes**
 
-The new Branches client added in #1437 means that existing methods on 
+The new Branches client added in #1437 means that existing methods on
 I(Observable)RepositoryClient are now marked as obsolete. Please update your
 usages to the new endpoints as these will be removed in a future release:
 
  - `client.Repository.GetBranch()` => `client.Repository.Branch.Get()`
  - `client.Repository.GetAllBranches()` => `client.Repository.Branch.GetAll()`
  - `client.Repository.EditBranch()` => `client.Repository.Branch.Edit()`
 
-There is also a change in how branch protection works with the API, due to 
+There is also a change in how branch protection works with the API, due to
 upstream changes. The existing methods have been marked as obsolete, but for
 the sake of brevity here are the details about what you should be doing today.
 
 The process for inspecting branch protection is now two steps:
 
- - first, check the branch returned by `client.Repository.Branch.Get()` or 
+ - first, check the branch returned by `client.Repository.Branch.Get()` or
    `client.Repository.Branch.GetAll()` has it's `Protected` property set to `true`.
 
  - then, a call to `client.Repository.Branch.GetBranchProtection()` will return
@@ -441,7 +441,7 @@ The process for inspecting branch protection is now two steps:
 Due to a programming error in the tool to generate these release notes, additional
 features were not properly documented for the previous release:
 
- - Reactions preview API support for issues, issue comments, commit comments and PR comments - #1335, #1341, #1405 via @maddin2016, @alfhenrik 
+ - Reactions preview API support for issues, issue comments, commit comments and PR comments - #1335, #1341, #1405 via @maddin2016, @alfhenrik
  - Repository Invitation preview API support - #1410 via @maddin2016
  - Added new fields for signature verification to Git Data Commit API - #1398 via @Sarmad93
 
@@ -484,7 +484,7 @@ exist in other parts of the API surface:
  - `I(Observable)GitHubClient.Repository.RepoCollaborators`
  - `I(Observable)GitHubClient.Repository.Commits`
 
-This method is no longer supported through the API and has been removed from Octokit.net.: 
+This method is no longer supported through the API and has been removed from Octokit.net.:
 
  - `I(Observable)GitHubClient.Authorization.RevokeAllApplicationAuthentications()`
 
@@ -510,12 +510,12 @@ documentation: http://octokitnet.readthedocs.io/en/latest/extensibility/#paginat
  - Add additional methods to `IEventsClient` - #1288 via @drasticactions
  - Add Organization Permissions preview API - #1342 via @ryangribble
  - Add GPG Keys preview API - #1343 via @alfhenrik
- 
+
 **Fixes**
 
  - Renamed `IUserKeysClient.GetAll()` to `IUserKeysClient.GetAllForCurrent()` - #1139 via @M-Zuber
  - Add `ItemStateFilter` enum to differentiate between search and list endpoints - #1140 via @prayankmathur
- - `RepositoriesClient.GetAllPublic()` fails for Enterprise instanes due to URI structure - #1204 via @ryangribble 
+ - `RepositoriesClient.GetAllPublic()` fails for Enterprise instanes due to URI structure - #1204 via @ryangribble
  - `ConfigureAwait(false)` usages added, eliminating deadlocks - #1248 via @shiftkey
  - Renamed `CompareResult.MergedBaseCommit` to fix serialization issue - #1265 via @kivancmuslu
  - Activity Feed now returns issues and repository events - #1288 via @drasticactions
@@ -525,11 +525,11 @@ documentation: http://octokitnet.readthedocs.io/en/latest/extensibility/#paginat
  - Add `ClosedBy` property to `Issue` - #1353 via @maddin2016
 
 **Other**
- 
+
  - Deleting now-obsolete code - #1224 via @M-Zuber
  - Centralize and cleanup the `Uri`s created in Octokit - #1287, #1290 via @dampir
- - Updated documentation links - #1289 via @radu-matei, #1250 via @SamTheDev 
- 
+ - Updated documentation links - #1289 via @radu-matei, #1250 via @SamTheDev
+
 **Breaking Changes**
 
  - `IUserKeysClient.GetAll()` was named incorrectly when it was originally implemented