-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Orgs Teams API #134
Comments
@haacked how do you want org teams to be implemented (I am new to this so please bear with me). Would something like this work?
Then should I add a property onto the org class called
Just wondering what the best way to go about this is... Thanks. |
@hahmed Thanks for offering to chip in. Take a look at the other clients, especially the Orgs client to get an idea of how clients are implemented. For example, instead of We also tend to create classes specifically for creating and updating entities. For example, we'd have a Also, for the enum, use standard .NET naming conventions (aka Pascal casing) for the fields: Our JSON serializer will fix it up to match what is expected by the API.
No, you'll need to create an |
@haacked It's cool, love to help - hope I can be of help. So far I got: Never understood this bit:
|
@hahmed go aheand and open a pull request. Just prefix it with WIP to let us know it's in progress. Much easier to discuss this in the pull request.
In pseudocode
|
@haacked Does that mean you want the Teams Api to be only available to end users via OrgsClient. For example: OrgsClient.Team.GetAllTeams(string org); etc. I assumed you wanted the TeamClient to be separate like I did so in my PR? |
Yep. We're trying to map our API to the structure of the GitHub API http://developer.github.com/v3/orgs/ For context see: #131 (comment) |
@haacked if the above pr gets merged I think that is everything that I needed to implement this feature. Let me know if I have missed anything so I can get this feature fully wrapped up. |
🆒 I found a potential issue with the PR. But most of it looks great! |
http://developer.github.com/v3/orgs/teams/
The text was updated successfully, but these errors were encountered: