Paging seems broken for Milestone.GetForRepository

[SimonCropp]

This

[Test]
[Explicit]
public async void OctokitTests()
{
    var githubUsername = Environment.GetEnvironmentVariable("OCTOKIT_GITHUBUSERNAME");
    var githubPassword = Environment.GetEnvironmentVariable("OCTOKIT_GITHUBPASSWORD");

    var gitHubClient = new GitHubClient(new ProductHeaderValue("Foo"))
    {
        Credentials = new Credentials(githubUsername, githubPassword)
    };

    var stopwatch = Stopwatch.StartNew();
    try
    {
        await gitHubClient.Issue.Milestone.GetForRepository("Particular", "NServiceBus", new MilestoneRequest { State = ItemState.Closed });
    }
    finally
    {
        Debug.WriteLine(stopwatch.ElapsedMilliseconds);
    }
}

causes, according to fiddler, looping requests on https://api.github.com/repositories/1056713/milestones?state=closed&sort=due_date&direction=asc

I killed mine after ~40 requests sinve i did not want o max my rate limit

[shiftkey]

It's to do with the ApplyParameters extension we use. Here's a failing test:

[Fact]
public void DoesNotDropPageFromQueryStringWhenUsingParameters()
{
    var uri = new Uri("https://api.github.com/repositories/1/milestones?state=closed&sort=due_date&direction=asc&page=2");

    var parameters = new Dictionary<string, string> { { "state", "open" }, { "sort", "other"} };

    var actual = uri.ApplyParameters(parameters);

    Assert.True(actual.Query.Contains("page=2"));
}

cc @haacked if he wants to look into this fix

[shiftkey]

I've started a PR for this fix here

https://github.com/octokit/octokit.net/tree/milestones-kill-your-rate-limit

I haven't confirmed the milestones client works as expected, but that's easy to chase down now...

[SimonCropp]

@haacked @shiftkey i notice 0.1.3 is out. did this one make it into the release?

[SimonCropp]

https://github.com/octokit/octokit.net/releases/tag/v0.1.3

"Fixed bug in applying query parameters that could cause paging to continually request the same page"

looks like it. so shall we close this?

[haacked]

@SimonCropp Can you try it out?

[SimonCropp]

Works on my machine