Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List pull requests files #747

Closed
shiftkey opened this issue Mar 10, 2015 · 2 comments · Fixed by #752
Closed

List pull requests files #747

shiftkey opened this issue Mar 10, 2015 · 2 comments · Fixed by #752
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

Reference: https://developer.github.com/v3/pulls/#list-pull-requests-files

This should live inside IPullRequestsClient.

This endpoint should return a Task<IReadOnlyList<PullRequestFile>> - you can basically C#-ify the hash properties returned from the endpoint and it should largely work as-is.

Tests would be great, use an old Octokit PR to ensure you're testing against live data :trollface:
@haacked haacked mentioned this issue Mar 10, 2015
Closed
7 tasks
@hnrkndrssn
Copy link
Contributor

I'll take this one, and #746 as it's in the same area

@hnrkndrssn hnrkndrssn mentioned this issue Mar 16, 2015
Merged
5 tasks
@shiftkey
Copy link
Member Author

👍

@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Missing pull requests bits hnrkndrssn/octokit.net
3 participants
@nickfloyd @shiftkey @hnrkndrssn