Move INotificationsClient to under IActivitiesClient #1019
Conversation
per octokit#1015. Top level client obsoleted.
| @@ -16,6 +16,7 @@ public interface IObservableGitHubClient : IApiInfoProvider | |||
| IObservableReleasesClient Release { get; } | |||
| IObservableSshKeysClient SshKey { get; } | |||
| IObservableUsersClient User { get; } | |||
| [System.Obsolete("The Notifications API belongs under the Activities client")] | |||
There was a problem hiding this comment.
💄 Perhaps make this message a bit more concise:
Notifications are now available under the Activities client. This will be removed in a future update.
|
|
|
Fixed |
|
@M-Zuber the rogue |
|
|
M-Zuber
force-pushed
the
inotifications-not-top-level
branch
from
52ee4e9
to
fe39762
Compare
|
Done and rebased |
also remove unwanted .nupkg
@naveensrinivasan have you seen this before? |
|
@shiftkey it is for the PortableReferenceAssemblies that we get from the xamarin. Looks like it is failing to get it failure because of timeout. Did you try re-running the build on the same commit? |
|
@naveensrinivasan it was failing for me on multiple builds yesterday (both for OS X and Linux) but seems to have come good today. Thanks for the 👀. |
|
@M-Zuber thanks! |
Move INotificationsClient to under IActivitiesClient
per #1015.
Top level client obsoleted.