Add missing fields to Repository class - HasPages, SubscribersCount, Size #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…starred count and not the watching count (which is in SubscribersCount). See octokit#699 for more info
|
Is some one able to give this one a 👍 ? I'd like to merge it in |
|
Do I count? 😃 Code looks good to me 👍 |
ryangribble
changed the title
nickfloyd
added
Type: Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1470 this PR adds back the
SubscribersCountproperty onRepositorywhich is the number of "watchers". This field was removed in the past however it does contain the correct value and would avoid additional API calls to theWatchedClientto retrieve this info.Also added some other fields that are missing in octokit.net such as
SizeandHasPagesFixes #1470