[.NET Core] - additional work #1544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuGet packaging information is now in the relevant project.json files
|
Closing this PR as we decided to break them into several PRs so we don't end up with unrelated work in a PR. New issues were created: #1546, #1547, #1548. Edit: @ryangribble, I tried creating these issues with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I started doing a bit of work to make the .NET Core solution tidier and on par with the existing one.
This includes:
OctokitandOctokit.ReactiveThere's some not-so-nice things going on in the formatting task.
CodeFormatterdoesn't support xproj/project.json, so the task creates a temp.csprojlisting all the.csfiles and feeds it to the formatter.Let me know if you'd like things made different.