New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ID to label #1947

Closed

patriksvensson wants to merge 1 commit into octokit:master from patriksvensson-forks:feature/label-id

Contributor

patriksvensson commented Feb 21, 2019

Couldn't find any tests that covers label, but if I've missed something please point it out and I'll fix it.

I also added an id parameter to the constructor which is pure cargo culting since I see no reference to the constructor anywhere 😄

Closes #1941


          Added ID to label

d519904

Closes octokit#1941

Contributor

M-Zuber commented Feb 21, 2019

If I recall correctly the ctors are used during deserialization.

Contributor

M-Zuber commented Feb 21, 2019

Here are the related tests that I found if it helps any:
https://github.com/octokit/octokit.net/blob/3147ddd6941bc45fbe5fb2a2a958eb61e10edf4a/Octokit.Tests.Integration/Clients/IssuesLabelsClientTests.cs

https://github.com/octokit/octokit.net/blob/3147ddd6941bc45fbe5fb2a2a958eb61e10edf4a/Octokit.Tests/Clients/IssuesLabelsClientTests.cs

https://github.com/octokit/octokit.net/blob/3147ddd6941bc45fbe5fb2a2a958eb61e10edf4a/Octokit.Tests/Reactive/ObservableIssuesLabelsClientTests.cs

Contributor Author

patriksvensson commented Feb 21, 2019

I see that there already is a PR for this (#1946) so I'm closing this one.

patriksvensson closed this

patriksvensson deleted the feature/label-id branch

March 30, 2019 23:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment