Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address new Travis build warning #2017

Merged
merged 2 commits into from Sep 24, 2019
Merged

address new Travis build warning #2017

merged 2 commits into from Sep 24, 2019

Conversation

shiftkey
Copy link
Member

Recent Travis builds on Linux seem to now have System.Range available, which clashes with our Octokit.Range type:

Models/SearchIssuesRequestTests.cs(187,32): error CS0104: 'Range' is an ambiguous reference between 'Octokit.Range' and 'System.Range' [/home/travis/build/octokit/octokit.net/Octokit.Tests/Octokit.Tests.csproj]

This should disambiguate it without impacting the other builds.

Oh, and the second commit is to tidy up the last xUnit warning (by opting in and skipping the test with a warning).

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #2017 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2017   +/-   ##
=======================================
  Coverage   70.77%   70.77%           
=======================================
  Files         535      535           
  Lines       14062    14062           
=======================================
  Hits         9952     9952           
  Misses       4110     4110

@shiftkey shiftkey merged commit aeb8d19 into master Sep 24, 2019
@shiftkey shiftkey deleted the force-range-to-octokit branch September 24, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant