Fixes #2143 - Support listing branch/pr per commit #2315
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2315 +/- ##
==========================================
- Coverage 65.99% 65.68% -0.31%
==========================================
Files 554 555 +1
Lines 14519 14625 +106
Branches 857 857
==========================================
+ Hits 9582 9607 +25
- Misses 4779 4860 +81
Partials 158 158
|
|
I'm happy to make any adjustments. The one major thing I was on the fence about was creating a new model for CommitPullRequests. It could easily be returned as the existing PullRequest model, but in sampling some responses from GitHub I was never getting information back for the properties I removed. If their absence is possibly explained by a different preview header or license level then it would make sense to return them as the existing PullRequest model. I was unable to find any documentation explaining the difference so I opted for a new model to make it clear those PullRequest properties will never be there for these calls. |
|
'👋 Hey Friends, this pull request has been automatically marked as |
|
Is this repo still active?
…On Tue, May 10, 2022, 4:37 PM github-actions[bot] ***@***.***> wrote:
'👋 Hey Friends, this pull request has been automatically marked as stale
because it has no recent activity. It will be closed if no further activity
occurs. Please add the pinned label if you feel that this issue needs to
remain open/active. Thank you for your contributions and help in keeping
things tidy!'
—
Reply to this email directly, view it on GitHub
<#2315 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOBO7I3AL45FLCLXL6AJC6DVJLJK3ANCNFSM4ZXK46VA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Yes! |
|
Can we re-open this PR and look to get it merged? |
|
I've reopened the PR and fixed the merge conflict. |
There was a problem hiding this comment.
Everything looks good, thank you for these contributions! ❤️ . I just left one comment about the preview header. Not a show stopper, but it's essentially dead code and unnecessary, given REST API previews were deprecated last year. We can remove the code in this PR or do a follow-up if needed.
Octokit/Helpers/AcceptHeaders.cs
Outdated
| @@ -13,5 +13,7 @@ public static class AcceptHeaders | |||
| /// </summary> | |||
| /// <remarks>https://developer.github.com/v3/repos/contents/#custom-media-types</remarks> | |||
| public const string RawContentMediaType = "application/vnd.github.v3.raw"; | |||
|
|
|||
| public const string ListBranchOrPullForCommitPreview = "application/vnd.github.groot-preview+json"; | |||
There was a problem hiding this comment.
Previews were deprecated last year for the REST API, so this header is no longer needed.
There was a problem hiding this comment.
I've removed the offending header!
|
Hi @nickfloyd - is there anything stopping this one from being merged? |
I think it's g2g. Let me give it a once over and get it merged in. Apologies for the delay. |
No description provided.