Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing master > main in integration tests #2489

Merged
merged 4 commits into from Jul 20, 2022
Merged

Fixing master > main in integration tests #2489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7448566
First file change, bit more than expected to do here - ObservableRepo…
JonruAlveus Jul 16, 2022
f304fe2
Changing a lot of master to main and fixing up tests so I can run the…
JonruAlveus Jul 19, 2022
3935275
Adding githubconstants file
JonruAlveus Jul 19, 2022
58c2afc
Finishing repo branch test. I wish there was a way to not have to wri…
JonruAlveus Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions Octokit.Reactive/Clients/IObservableReferencesClient.cs
View file
Open in desktop
Expand Up @@ -20,7 +20,7 @@ public interface IObservableReferencesClient
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/master" or "tags/release-1"</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/main" or "tags/release-1"</param>
/// <returns></returns>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
Expand All @@ -33,7 +33,7 @@ public interface IObservableReferencesClient
/// http://developer.github.com/v3/git/refs/#get-a-reference
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/master" or "tags/release-1"</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/main" or "tags/release-1"</param>
/// <returns></returns>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
Expand Down Expand Up @@ -162,7 +162,7 @@ public interface IObservableReferencesClient
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/master" or "tags/release-1"</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/main" or "tags/release-1"</param>
/// <param name="referenceUpdate">The updated reference data</param>
/// <returns></returns>
IObservable<Reference> Update(string owner, string name, string reference, ReferenceUpdate referenceUpdate);
Expand All @@ -174,7 +174,7 @@ public interface IObservableReferencesClient
/// http://developer.github.com/v3/git/refs/#update-a-reference
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/master" or "tags/release-1"</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/main" or "tags/release-1"</param>
/// <param name="referenceUpdate">The updated reference data</param>
/// <returns></returns>
IObservable<Reference> Update(long repositoryId, string reference, ReferenceUpdate referenceUpdate);
Expand All @@ -187,7 +187,7 @@ public interface IObservableReferencesClient
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/master" or "tags/release-1"</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/main" or "tags/release-1"</param>
/// <returns></returns>
IObservable<Unit> Delete(string owner, string name, string reference);

Expand All @@ -198,7 +198,7 @@ public interface IObservableReferencesClient
/// http://developer.github.com/v3/git/refs/#delete-a-reference
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/master" or "tags/release-1"</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/main" or "tags/release-1"</param>
/// <returns></returns>
IObservable<Unit> Delete(long repositoryId, string reference);
}
Expand Down
8 changes: 4 additions & 4 deletions Octokit.Reactive/Clients/IObservableRepositoryContentsClient.cs
View file
Open in desktop
Expand Up @@ -163,7 +163,7 @@ public interface IObservableRepositoryContentsClient
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually master)</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually main)</param>
/// <param name="path">The content path</param>
IObservable<RepositoryContent> GetAllContentsByRef(string owner, string name, string reference, string path);

Expand All @@ -187,7 +187,7 @@ public interface IObservableRepositoryContentsClient
/// See the <a href="https://developer.github.com/v3/repos/contents/#get-contents">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually master)</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually main)</param>
/// <param name="path">The content path</param>
IObservable<RepositoryContent> GetAllContentsByRef(long repositoryId, string reference, string path);

Expand All @@ -196,14 +196,14 @@ public interface IObservableRepositoryContentsClient
/// </summary>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually master)</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually main)</param>
IObservable<RepositoryContent> GetAllContentsByRef(string owner, string name, string reference);

/// <summary>
/// Returns the contents of the home directory in a repository.
/// </summary>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually master)</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually main)</param>
IObservable<RepositoryContent> GetAllContentsByRef(long repositoryId, string reference);

/// <summary>
Expand Down
20 changes: 10 additions & 10 deletions Octokit.Reactive/Clients/ObservableReferencesClient.cs
View file
Open in desktop
Expand Up @@ -32,7 +32,7 @@ public ObservableReferencesClient(IGitHubClient client)
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/master" or "tags/release-1"</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/main" or "tags/release-1"</param>
/// <returns></returns>
public IObservable<Reference> Get(string owner, string name, string reference)
{
Expand All @@ -50,7 +50,7 @@ public IObservable<Reference> Get(string owner, string name, string reference)
/// http://developer.github.com/v3/git/refs/#get-a-reference
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/master" or "tags/release-1"</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/main" or "tags/release-1"</param>
/// <returns></returns>
public IObservable<Reference> Get(long repositoryId, string reference)
{
Expand Down Expand Up @@ -148,9 +148,9 @@ public IObservable<Reference> GetAllForSubNamespace(string owner, string name, s
/// <param name="options">Options for changing the API response</param>
/// <remarks>
/// The subNamespace parameter supports either the fully-qualified ref
/// (prefixed with "refs/", e.g. "refs/heads/master" or
/// (prefixed with "refs/", e.g. "refs/heads/main" or
/// "refs/tags/release-1") or the shortened form (omitting "refs/", e.g.
/// "heads/master" or "tags/release-1")
/// "heads/main" or "tags/release-1")
/// </remarks>
public IObservable<Reference> GetAllForSubNamespace(string owner, string name, string subNamespace, ApiOptions options)
{
Expand Down Expand Up @@ -192,9 +192,9 @@ public IObservable<Reference> GetAllForSubNamespace(long repositoryId, string su
/// <param name="options">Options for changing the API response</param>
/// <remarks>
/// The subNamespace parameter supports either the fully-qualified ref
/// (prefixed with "refs/", e.g. "refs/heads/master" or
/// (prefixed with "refs/", e.g. "refs/heads/main" or
/// "refs/tags/release-1") or the shortened form (omitting "refs/", e.g.
/// "heads/master" or "tags/release-1")
/// "heads/main" or "tags/release-1")
/// </remarks>
public IObservable<Reference> GetAllForSubNamespace(long repositoryId, string subNamespace, ApiOptions options)
{
Expand Down Expand Up @@ -252,7 +252,7 @@ public IObservable<Reference> Create(long repositoryId, NewReference reference)
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/master" or "tags/release-1"</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/main" or "tags/release-1"</param>
/// <param name="referenceUpdate">The updated reference data</param>
/// <returns></returns>
public IObservable<Reference> Update(string owner, string name, string reference, ReferenceUpdate referenceUpdate)
Expand All @@ -272,7 +272,7 @@ public IObservable<Reference> Update(string owner, string name, string reference
/// http://developer.github.com/v3/git/refs/#update-a-reference
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/master" or "tags/release-1"</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/main" or "tags/release-1"</param>
/// <param name="referenceUpdate">The updated reference data</param>
/// <returns></returns>
public IObservable<Reference> Update(long repositoryId, string reference, ReferenceUpdate referenceUpdate)
Expand All @@ -291,7 +291,7 @@ public IObservable<Reference> Update(long repositoryId, string reference, Refere
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/master" or "tags/release-1"</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/main" or "tags/release-1"</param>
/// <returns></returns>
public IObservable<Unit> Delete(string owner, string name, string reference)
{
Expand All @@ -309,7 +309,7 @@ public IObservable<Unit> Delete(string owner, string name, string reference)
/// http://developer.github.com/v3/git/refs/#delete-a-reference
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/master" or "tags/release-1"</param>
/// <param name="reference">The canonical name of the reference without the 'refs/' prefix. e.g. "heads/main" or "tags/release-1"</param>
/// <returns></returns>
public IObservable<Unit> Delete(long repositoryId, string reference)
{
Expand Down
8 changes: 4 additions & 4 deletions Octokit.Reactive/Clients/ObservableRepositoryContentsClient.cs
View file
Open in desktop
Expand Up @@ -281,7 +281,7 @@ public IObservable<RepositoryContent> GetAllContents(long repositoryId)
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually master)</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually main)</param>
/// <param name="path">The content path</param>
public IObservable<RepositoryContent> GetAllContentsByRef(string owner, string name, string reference, string path)
{
Expand Down Expand Up @@ -325,7 +325,7 @@ public IObservable<byte[]> GetRawContentByRef(string owner, string name, string
/// See the <a href="https://developer.github.com/v3/repos/contents/#get-contents">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually master)</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually main)</param>
/// <param name="path">The content path</param>
public IObservable<RepositoryContent> GetAllContentsByRef(long repositoryId, string reference, string path)
{
Expand All @@ -340,7 +340,7 @@ public IObservable<RepositoryContent> GetAllContentsByRef(long repositoryId, str
/// </summary>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually master)</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually main)</param>
public IObservable<RepositoryContent> GetAllContentsByRef(string owner, string name, string reference)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Expand All @@ -354,7 +354,7 @@ public IObservable<RepositoryContent> GetAllContentsByRef(string owner, string n
/// Returns the contents of the home directory in a repository.
/// </summary>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually master)</param>
/// <param name="reference">The name of the commit/branch/tag. Default: the repository’s default branch (usually main )</param>
public IObservable<RepositoryContent> GetAllContentsByRef(long repositoryId, string reference)
{
Ensure.ArgumentNotNullOrEmptyString(reference, nameof(reference));
Expand Down