Drop support for .NET 4.6 #2521
Conversation
| @@ -536,7 +536,7 @@ public async Task UpdatesNameObsolete() | |||
| using (var repoContext = await _github.CreateUserRepositoryContext()) | |||
| { | |||
| var updatedName = Helper.MakeNameWithTimestamp("updated-repo"); | |||
| var update = new RepositoryUpdate(updatedName); | |||
| var update = new RepositoryUpdate() { Name = updatedName }; | |||
There was a problem hiding this comment.
This addressed a compiler warning - I wanted to ensure the output was as clean as possible and, therefore, clean a little bit of the house regardless of whether it was a related change or not.
There was a problem hiding this comment.
These two tests were there to test the obsolete method, which technically does still work. The previous 2 tests in the file check the newer way of doing it, so if we don't want the warnings it would be better to get rid of those two tests (ending Obsolete) entirely 👍
There was a problem hiding this comment.
Great point. I'm thinking we also opt to remove the constructor as well given we are making a breaking change with this change set - and I can note it in the release.
Co-authored-by: Jamie Magee <jamie.magee@gmail.com>
…during CI - since no .net framework version is specified
|
Packages inspected from CI. Before Octokit After Octokit Before Octokit.Reactive After Octokit.Reactive |
|
cc: @eriawan @JonruAlveus |
| @@ -536,7 +536,7 @@ public async Task UpdatesNameObsolete() | |||
| using (var repoContext = await _github.CreateUserRepositoryContext()) | |||
| { | |||
| var updatedName = Helper.MakeNameWithTimestamp("updated-repo"); | |||
| var update = new RepositoryUpdate(updatedName); | |||
| var update = new RepositoryUpdate() { Name = updatedName }; | |||
There was a problem hiding this comment.
These two tests were there to test the obsolete method, which technically does still work. The previous 2 tests in the file check the newer way of doing it, so if we don't want the warnings it would be better to get rid of those two tests (ending Obsolete) entirely 👍
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition=" '$(TargetFramework)' == 'net46' "> | ||
| <DefineConstants>$(DefineConstants);HAS_ENVIRONMENT;HAS_REGEX_COMPILED_OPTIONS;SIMPLE_JSON_INTERNAL;SIMPLE_JSON_OBJARRAYINTERNAL;SIMPLE_JSON_READONLY_COLLECTIONS;HAS_SERVICEPOINTMANAGER</DefineConstants> |
There was a problem hiding this comment.
I think there are some usages of these constants in the code, should these be removed/tidied as well as part of this?
For example HAS_ENVIRONMENT has been removed entirely but is present/used in Connection.cs.
There was a problem hiding this comment.
Good highlight. I can clean these up as well while I am in there.
There was a problem hiding this comment.
Scratch that. There are implementations in the other projects that I'd like to take a closer look at - this is feeling like a separate changeset. I'm going to hold off so that we can do this separately - #2526
|
Sorry to join late! Thanks for this PR, now we can move to newer .NET Framework version! 👍 |
|
release_notes: Drops support for .NET 4.6 and updates all projects to .NET Standard 2.0 |
nickfloyd
added
Type: Breaking change
Fixes: #2500
Already covered by the explanation via @JamieMagee - this needs to be done so we can move forward with the framework and innovate using the new APIs and assemblies.
Highlights from the issue description:
For reference, these are the supported versions going forward