-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Self-hosted runners and Self-hosted runner groups APIs #2695
Conversation
@lineville is this still something you're interested in getting in? |
Yes, I'd love to get this in. I have been working on adding some integration tests. I have been facing some issues with authenticating given that some of the tests need to access an enterprise etc. Unit tests and Convention tests and docs are done ✅, was just trying to finish up some integration tests, or at least validate somehow it's functional end to end before opening this PR up for review. @kfcampbell If you have any ideas about running integration tests against an enterprise, or any details you might have about how the existing integration tests are run locally or in CI would be super helpful 🙇 |
As far as I'm aware, this the only script used in our automated checks, which runs unit tests but not any integration tests. I think we'd be working from scratch with enterprise integration testing. |
@kfcampbell Thanks! I won't worry too much about having exhaustive integration tests then, given that it's not run in CI anyways. I'll open this PR up for review shortly! |
@kfcampbell I've pushed up some final changes and opened this up for review! No rush or anything, but just curious what the release cadence looks like for this project? Are you planning to cut a release sometime soon? |
@lineville release cadence is ad-hoc depending on PRs that have been merged. When this goes in, we can cut a release shortly thereafter. |
@kfcampbell Just bumping this 😄, any ideas when we could expect this to be merged and released? Is there anything from my end that might be holding this up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you for the changes ❤️
Resolves #2692 by implementing support for the following API's
Self-Hosted Runners
Self-Hosted Runner Groups
Behavior
Before the change?
ActionsSelfHostedRunnersClient
andActionsSelfHostedRunnerGroupsClient
we're empty and not implementedAfter the change?
ActionsSelfHostedRunnersClient
andActionsSelfHostedRunnerGroupsClient
have been implemented (non-exhaustively) to include several of the available API's (listed above)Other information
Runner
,RunnerResponse
,RunnerApplication
andRunnerApplicationResponse
Self-Hosted Runner
andSelf-Hosted Runner Groups
that are left unimplemented after this PRAdditional info
Pull request checklist
☝️ Unable to add labels to the PR 😕 but should be tagged with feature
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug
Type: Feature
Type: Documentation
Type: Maintenance