Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GetBranches method #270

Merged
merged 4 commits into from
Jan 5, 2014
Merged

Added GetBranches method #270

merged 4 commits into from
Jan 5, 2014

Conversation

goalie7960
Copy link
Contributor

No description provided.

@@ -143,5 +143,7 @@ public interface IRepositoriesClient
/// See the <a href="http://developer.github.com/v3/repos/collaborators/">Collaborators API documentation</a> for more details
/// </remarks>
IRepoCollaboratorsClient RepoCollaborators { get; }

Task<IReadOnlyList<Branch>> GetAllBranches(string owner, string name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some XML documentation to this? Feel free to base it on the other methods in this code file...

@shiftkey
Copy link
Member

Looks good - just a few little things to tidy up.

I've opened up #277 to cover the integration test - we should have all the necessary bits to do this lying around.

@shiftkey
Copy link
Member

You'll need to run .\build FixProjects to include the Branch.cs file in with the Mono* projects...

@goalie7960
Copy link
Contributor Author

I've updated the documentation stuff you requested. I ran build.cmd and didn't see any errors, not sure how else to verify the FixProjects thing.

@shiftkey
Copy link
Member

shiftkey commented Jan 3, 2014

@goalie7960 so we can pass arguments to build.cmd to specify custom tasks - that's how the FixProjects task is invoked.

So running .\build.cmd FixProjects from the command line is how you can do that.

Oh, and you'll need to merge master into the branch to resolve some merge conflicts with the ApiUrls.cs file.

@goalie7960
Copy link
Contributor Author

Merged and projects have been fixed.

shiftkey added a commit that referenced this pull request Jan 5, 2014
@shiftkey shiftkey merged commit a1e3e98 into octokit:master Jan 5, 2014
@shiftkey
Copy link
Member

shiftkey commented Jan 5, 2014

Thanks!

445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants