Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve repo debugger display #2712

Merged
merged 1 commit into from
May 9, 2023
Merged

Improve repo debugger display #2712

merged 1 commit into from
May 9, 2023

Conversation

martincostello
Copy link
Contributor

Resolves #2711.

Behavior

Before the change?

  • The debugger display string for Repository shows Owner: Octokit.User.

After the change?

  • The debugger display string for Repository shows Owner: {repository owner login}.

Other information

  • N/A

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@martincostello
Improve repo debugger display
789ee2e 
Show the repo's owner login in the debugger display string for `Repository` instead of the type name.
nickfloyd
nickfloyd approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change @martincostello ❤️

@nickfloyd nickfloyd added Priority: Normal Type: Feature New feature or request labels May 9, 2023
@nickfloyd nickfloyd merged commit ecf5af4 into octokit:main May 9, 2023
6 checks passed
@martincostello martincostello deleted the improve-repo-debugger-display branch May 9, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Improve debugger display string for Repository model
2 participants
@martincostello @nickfloyd