Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for making branches read-only #2715

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

jefflill
Copy link
Contributor

@jefflill jefflill commented May 20, 2023

Resolves #2714


Behavior

Before the change?

  • Octokit.net doesn't currently support making branches read-only

After the change?

Other information

  • The existing unit tests pass
  • I didn't see any related integration unit tests in your repo, but I have verified this in unit tests for our repo using this.

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
    I didn't see any related integration unit tests in your repo, but I have verified this in unit tests for our repo using this.
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

Pull request type

Please add the corresponding label for change this PR introduces:

Type: Feature


Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the changes. ❤️ There is just one minor modification needed before we can merge this in.

<PackageTags>GitHub API Octokit linqpad-samples dotnetcore</PackageTags>
<Copyright>Copyright GitHub 2017</Copyright>
</PropertyGroup>
<PropertyGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jefflill, Thanks for this change! ❤️ . We use spaces in this project - they need to be updated in this file. Would you mind either:

  1. Updating this to reflect what I mentioned above and pushing the update to this PR or...
  2. Setting the fork to give maintainers write access and I'd be glad to make the change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jefflill, Just a gentle bump on this. Let me know if either option above works for you. Thanks again for your contributions!

@nickfloyd nickfloyd added the Type: Feature New feature or request label Aug 3, 2023
@nickfloyd nickfloyd merged commit 7fe4c4e into octokit:main Aug 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEAT]: support locking branches
2 participants