Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActionsSelfHostedRunnersClient Delete Calls #2740

Merged
merged 6 commits into from
Jul 5, 2023

Conversation

lineville
Copy link
Contributor


Behavior

Before the change?

  • Calls to all of the Delete___Runner methods would throw an exception caused by passing the wrong kind of Object to the underlying Delete call. We we're previously passing ApiOptions which are the wrong type and not relevant.

After the change?

  • Calls to all of the Delete___Runner methods succeed.
  • Calls to the Create__Token methods allow for passing a CancellationToken and still succeed.

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label Jul 5, 2023
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM ❤️. Thanks for the 🏕️ work on the comments and descriptions as well.

@nickfloyd nickfloyd merged commit 0c901dc into octokit:main Jul 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Fix ActionsSelfHostedRunnersClient Delete calls
2 participants