Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added readonly to fields that are never modified #2759

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Added readonly to fields that are never modified #2759

merged 3 commits into from
Aug 11, 2023

Conversation

Lehonti
Copy link
Contributor

@Lehonti Lehonti commented Aug 2, 2023

Resolves #2758


Before the change?

No behavior change. The change is purely in the semantics of the code

After the change?

No behavior change. The change is purely in the semantics of the code

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features) (does not apply)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features) (does not apply)

Does this introduce a breaking change?

No. All changes are local in the classes they were introduced

  • Yes
  • No

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kfcampbell kfcampbell merged commit d46527d into octokit:main Aug 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[MAINT]: Adding readonly to fields that are never modified
2 participants