Allow the constructor for ProductHeaderValue to accept a framework version of the object
#2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfcampbell
reviewed
Dec 4, 2023
kfcampbell
reviewed
Dec 4, 2023
| /// See more information regarding User-Agent requirements here: https://developer.github.com/v3/#user-agent-required | ||
| /// </remarks> | ||
| /// <param name="name">The <see cref="System.Net.Http.Headers.ProductHeaderValue"/>.</param> | ||
| public ProductHeaderValue(System.Net.Http.Headers.ProductHeaderValue productHeader) |
There was a problem hiding this comment.
Is this the meaningful part of the change? I'm having a hard time figuring out how the internal _productHeaderValue was set before the change.
There was a problem hiding this comment.
The changing of the constructor from private to public is the meaningful bit yeah. All other constructors call it.
…version of the object
kfcampbell
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
I think this is fairly straightforward. Currently, if you already have a
System.Net.Http.Headers.ProductHeaderValue, you have to deconstruct it to pass it to the Octokit constructor. Then, it proceeds to just make an unnecessary copy of it.Simplify things by allowing one to be passed in directly.