Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add Rocket & Eyes reactions to ReactionSummary #2847

Merged
merged 3 commits into from Jan 16, 2024
Merged

[feat] Add Rocket & Eyes reactions to ReactionSummary #2847

merged 3 commits into from Jan 16, 2024

Conversation

Misha-133
Copy link
Contributor

Resolves #2838

Before the change?

It wasn't possible to get the count of eyes or rocket reactions from ReactionSummary
*

After the change?

ReactionSummary now has Eyes & Rocket properties
*

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)

nickfloyd
nickfloyd approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Misha-133 thanks for the contributions here! ❤️

@nickfloyd nickfloyd merged commit 4254287 into octokit:main Jan 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: missing Rocket & Eyes reactions in ReactionSummary
2 participants
@Misha-133 @nickfloyd