Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Allow build version to be passed in to build.ps1 via command line #2864

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

SlyckLizzie
Copy link
Contributor

@SlyckLizzie SlyckLizzie commented Jan 26, 2024

Resolves #ISSUE_NUMBER


Before the change?

  • The build.ps1 script would require setup on the machine in order to parse a version number when building the nupkg file.

After the change?

  • A custom version can be forced in by specifying the -ForceVersion parameter

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@SlyckLizzie
Copy link
Contributor Author

usage: build.ps1 -ForceVersion 9.1.2-beta3

Not using the flag will revert to the default version acquisition technique

@nickfloyd nickfloyd added the Type: Feature New feature or request label Feb 1, 2024
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add here @SlyckLizzie, thx again! ❤️

@nickfloyd nickfloyd merged commit e87aa64 into octokit:main Feb 1, 2024
5 checks passed
b3b00 pushed a commit to b3b00/octokit.net that referenced this pull request Feb 4, 2024
…n-deleting-file

* main:
  [Feat] Allow build version to be passed in to build.ps1 via command line (octokit#2864)
  [Feat] Add Repository Autolinks Client (octokit#2868)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants