fix: "zip" Content-Type resulting in null Stream for Artifacts on Blob Storage #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack0x539
approved these changes
Apr 14, 2024
nickfloyd
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Thanks for the docs describing why this is necessary, tests and validation here. ❤️ I'm going to take a note to see if I can determine why blob storage is behaving like this - I just don't feel good about the behavior of storage in this case.
Thank you for the quick turn around on this.
nickfloyd
changed the title
|
Thanks @nickfloyd ! Any chance of releasing a patch version for this? 11.0.1 maybe. Would unblock my pipeline on another project 😄 |
|
Hey @thomhurst Absolutely... the new patch is building / releasing now. Thanks again for the efforts here! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2898
Sorry, the last one didn't actually solve it because the Content-Type wasn't being set properly by the
System.Netclasses - Probably due to an invalid format.