Add since parameter for public repositories
#774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review cc @shiftkey |
|
|
||
| public class TheGetAllPublicSinceMethod | ||
| { | ||
| [IntegrationTest] |
There was a problem hiding this comment.
I think this test is going to run forever, but I'll mute this as part of preparing the next release
There was a problem hiding this comment.
Currently, yes it most likely will 😄 but when I created the test, it ran for a few seconds, so I can at least say I tested the feature 😬
I'll mute it when I do the fix for the comment below.
|
Looks good, just a couple of minor things. |
|
Test updated and muted |
| gitHubClient.Connection.Get<List<Repository>>(secondPageUrl, null, null) | ||
| .Returns(Task.Factory.StartNew<IApiResponse<List<Repository>>>(() => secondPageResponse)); | ||
| gitHubClient.Connection.Get<List<Repository>>(thirdPageUrl, null, null) | ||
| .Returns(Task.Factory.StartNew<IApiResponse<List<Repository>>>(() => lastPageResponse)); |
There was a problem hiding this comment.
💄 Task.FromResult here there and everywhere?
|
A couple of questions 🐶 |
Adding 💄 `Task.FromResult` to tests
|
Questions answered ✊ ✌️ |
|
Thanks! |
shiftkey
added a commit
that referenced
this pull request
Apr 12, 2015
Add `since` parameter for public repositories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #686 part deux