Targeting mono #995
Targeting mono #995
Conversation
removed DocPlagiarizer Fixed tests removed unused variable removed unused variable that was causing the build to fail fixed the file name casing. updated the nugget.exe to download System.Net.Http PCL is required for mono more fixes for travis
# Conflicts: # .travis.yml
Is package restore not working as expected? |
Fixed the path which was in wrong case
|
@shiftkey OSX file system isn't case sensitive which is causing me an issue. So it works on mine but does not work on the linux. Took care of |
Fixes for travis-ci build
|
And now I'm kinda curious why AppVeyor isn't reporting the status of this PRs... |
| - linux | ||
| install: | ||
| - curl -sS http://storage.bos.xamarin.com/bot-provisioning/PortableReferenceAssemblies-2014-04-14.zip > /tmp/pcl-assemblies.zip | ||
| - unzip /tmp/pcl-assemblies.zip -d /tmp/pcl-assemblies && mv /tmp/pcl-assemblies/PortableReferenceAssemblies-2014-04-14 /tmp/pcl-assemblies/.NETPortable |
There was a problem hiding this comment.
You shouldn't need this, the PCL assemblies are preinstalled on Travis.
There was a problem hiding this comment.
I tried this one also. It works on OSX but fails on linux for the same commit.
OSX - https://travis-ci.org/naveensrinivasan/octokit.net/jobs/96858329
linux - https://travis-ci.org/naveensrinivasan/octokit.net/jobs/96858330
There was a problem hiding this comment.
I think you meant https://travis-ci.org/naveensrinivasan/octokit.net/jobs/96850533.
If you look at the actual build log, the error there is from something completely unrelated (System.TypeInitializationException: The type initializer for 'System.Collections.Generic.List'1' threw an exception. ---> System.Threading.ThreadAbortException: during tests).
There was a problem hiding this comment.
But it works on OSX and fails on linux. The same code. Do you know why?
And when I include PCL it does not fail every time.
There was a problem hiding this comment.
PCL has nothing to do with it, that's just a coincidence (the random ThreadAbortException looks like a Mono bug).
|
@akoeplinger thanks for the review comments! ❤️ |
|
@shiftkey I am done with changes. There is a conflict on the |
|
@naveensrinivasan as this is targeting |
|
@shiftkey Will do that. Thanks |
|
@shiftkey I resolved the conflict. The build failed 😫 in appveyor and linux because of |
|
@naveensrinivasan ugh, feel free to mute that test and I'll open an issue to investigate |
|
@shiftkey Thanks! Done! |
| @@ -90,7 +90,6 @@ public class TheGetAllForCurrentMethod | |||
| gitHubClient.Connection.Received(1).Get<List<Repository>>(thirdPageUrl, null, null); | |||
| } | |||
|
|
|||
| [Fact] | |||
There was a problem hiding this comment.
Can you keep this [Fact] around with the Skip attribute set?
[Fact(Skip = "See https://github.com/octokit/octokit.net/issues/1011 for issue to investigate this further")]
|
@shiftkey Got it done! Thanks |
| @@ -2,9 +2,14 @@ | |||
| <repositories> | |||
| <repository path="..\Octokit.Reactive\packages.config" /> | |||
| <repository path="..\Octokit.Tests.Conventions\packages.config" /> | |||
| <repository path="..\Octokit.Tests\packages.Octokit.Tests.config" /> | |||
There was a problem hiding this comment.
@naveensrinivasan sorry, I should have been clearer here - these new entries are just duplicates of previous ones - can you 🔥 them to simplify the diff?
There was a problem hiding this comment.
Eh, I'll clean this up after master goes green again.
|
@naveensrinivasan thanks again, outstanding stuff!
|
Targeting mono.