ARC not enabled in CocoaPods Podspec

[jacksonh]

I think I'm missing something obvious with OctoKit. This is a small sample app I wrote this morning:

https://github.com/jacksonh/octophile

Running this app in Instruments with the Leaks template each time I tap the Fetch User Info my OCTResponse objects are shown as leaking.

Am I doing something wrong with my subscriptions here?

[jspahrsummers]

No, it looks fine to me.

Can you upload the full trace somewhere?

[jacksonh]

You can grap my trace from here, I let snapshotting go every 10 seconds, the first set of leaks is the login, then after that tapping the fetch button.

http://hsc.io/octophile.trace.zip

[jspahrsummers]

Sooo… it looks like we might be creating retain cycles from RACSignals to themselves (because of the hidden self in NSAssert).

We've not seen this issue because we don't use CocoaPods, so the Release build of OctoKit doesn't have assertions.

trololo

[jacksonh]

Thank you! That also explains why I couldn't duplicate with GroceryList

[joshaber]

So this looks like a problem with how CocoaPods is configuring OctoKit for octophile. It's not compiling OctoKit with ARC (and maybe the same for all the other dependencies?). You can see this by Analyzing or inserting retain/release/autoreleases in OctoKit.

[jacksonh]

OK, I'll work on this since its somewhat critical for me. And yes, I was wondering why the hell I could release things when testing.

[jacksonh]

Sigh, you are correct. The Pods project had ARC disabled. Confirmed that there are no leaks with that fixed.

[jacksonh]

OK, this is fixed in CocoaPods. CocoaPods/Specs#7144

[joshaber]

🤘