Fix retain cycle in -oct_parsedResults

[jspahrsummers]

Because NSAssert is a huge trollface. Hopefully fixes #142.

@jacksonh Can you give this branch a try?

[dannygreg]

lolobjc.

[dannygreg]

lol

[jacksonh]

Here is an updated trace: http://hsc.io/octophile02.trace.zip results look similar but I didn't dig in too much.

[jspahrsummers]

As far as I can tell, it seems to be saying that the leak is originating within this -map: block.

Can you try removing the assertion there, just out of curiosity? It might be an ARC bug or another weird thing with NSAssert.

[jacksonh]

Sorry for the delay. Here is an updated trace with that assert removed.

http://hsc.io/octophile-03.trace.zip

[jspahrsummers]

I'm out of ideas here.

@octokit/octokit-objc Anyone else wanna take a look?

[joshaber]

Looks like the original problem is with how CocoaPods configured OctoKit.

This shouldn't be necessary.

[jacksonh]

@joshaber can you expand on the config issue? I can try fixing the Podspec.

I'll also try building the app with the non-CocoaPods version and see if I can duplicate.

[joshaber]

@jacksonh I wrote a bit more in #142.