Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #1177

Closed
plutino opened this issue Dec 30, 2019 · 9 comments
Closed

New release? #1177

plutino opened this issue Dec 30, 2019 · 9 comments

Comments

@plutino
Copy link

plutino commented Dec 30, 2019

Last release was 9 months ago in March, and there are lots of valuable fixes in current master. Especially #1154 fixes a very annoying deprecation message from upstream Faraday change.

Please create a new release to allow easy access to these fixes and new features.

@jdeluyck
Copy link

jdeluyck commented Jan 1, 2020

Version 1.0.0 of Faraday has been released, which breaks with the latest version of Octokit. Please release a new version!

@Atem18
Copy link

Atem18 commented Jan 1, 2020

Can confirm, can’t build anymore my Jekyll website. :(

@parkr
Copy link
Contributor

parkr commented Jan 2, 2020

Hi @hmharvey! Are you able to cut releases of this gem? Thanks!

@indigok
Copy link

indigok commented Jan 2, 2020

Hello all 👋yes, we'll have a release out early next week when we're back from the holidays.

@akhilles
Copy link

akhilles commented Jan 2, 2020

octokit gem is completely broken atm due to the faraday 1.0.0 release. would it be possible to use some sort of semantic versioning in the gemspec to avoid situations like this in the future? This needs to be stricter: spec.add_dependency 'faraday', '>= 0.9'

Traceback (most recent call last):
	2: from ...
	1: from /usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- octokit (LoadError)
	12: from ...
	11: from /usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:34:in `require'
	10: from /usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:130:in `rescue in require'
	 9: from /usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:130:in `require'
	 8: from /var/lib/gems/2.6.0/gems/octokit-4.14.0/lib/octokit.rb:4:in `<top (required)>'
	 7: from /usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
	 6: from /usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
	 5: from /var/lib/gems/2.6.0/gems/octokit-4.14.0/lib/octokit/default.rb:1:in `<top (required)>'
	 4: from /usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
	 3: from /usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
	 2: from /var/lib/gems/2.6.0/gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:9:in `<top (required)>'
	 1: from /var/lib/gems/2.6.0/gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:11:in `<module:Octokit>'
/var/lib/gems/2.6.0/gems/octokit-4.14.0/lib/octokit/middleware/follow_redirects.rb:14:in `<module:Middleware>': uninitialized constant Faraday::Error::ClientError (NameError)

@akhilles
Copy link

akhilles commented Jan 2, 2020

Temporary workaround for people running into the same issue:

gem install specific_install
gem specific_install -l https://github.com/octokit/octokit.rb.git

or if using Gemfile:

gem 'octokit', :git => 'https://github.com/octokit/octokit.rb.git'

@tarebyte
Copy link
Member

tarebyte commented Jan 2, 2020

I've released https://github.com/octokit/octokit.rb/releases/tag/v4.15.0 which is now live on Rubygems.

Shout out to @hmharvey for putting in the time to write the release notes ✨

Happy New Year y'all

@parkr
Copy link
Contributor

parkr commented Jan 2, 2020

Thank you, @tarebyte and @hmharvey!

@Atem18
Copy link

Atem18 commented Jan 3, 2020

Thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants