Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new CodeQL variants analysis endpoints, new code scanning repository rule, description updates, removes Copilot usage metrics endpoint #452

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

octokitbot
Copy link
Collaborator

I found new changes in GitHub's official OpenAPI specifications and thought I'd let you know about it 👋🤖

I can't tell if the changes include fixes, features, breaking changes or just cache updates, you'll have to figure that out on yourself and adapt the commit messages accordingly to trigger the right release, see our commit message conventions.

@octokitbot octokitbot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label May 13, 2024
@wolfy1339 wolfy1339 changed the title 🤖📯 GitHub OpenAPI Update feat: new CodeQL variants analysis endpoints, new code scanning repository rule, description updates, removes Copilot usage metrics endpoint May 13, 2024
@wolfy1339
Copy link
Member

wolfy1339 commented May 13, 2024

Was the /orgs/{org}/team/{team_slug}/copilot/usage endpoint intentionally removed?

@wolfy1339
Copy link
Member

I can't get the update_dry_run workflow to trigger. This will need to be merged manually @gr2m @kfcampbell @nickfloyd

@wolfy1339 wolfy1339 added the Type: Breaking change Used to note any change that requires a major version bump label May 13, 2024
@kfcampbell
Copy link
Member

kfcampbell commented May 13, 2024

The update_dry_run check hasn't worked in some time; we've been merging without it.

I don't have any knowledge on the Copilot API changes, though I suppose I would trust the process unless I had a reason to doubt it.

@wolfy1339 are you comfortable with me merging as-is (with a breaking change in the commit message body)?

@gr2m
Copy link
Contributor

gr2m commented May 13, 2024

I would suggest to add a deprecation like https://github.com/octokit/openapi/blob/main/changes/2021-04-30-operation-code-scanning-list-alert-instances.json, if the endpoint is infact being deprecated. If we remove an endpoint without a breaking change then people will run into cryptic TypeScript errors when using https://github.com/octokit/plugin-rest-endpoint-methods.js (used by octokit, @octokit/rest, probot, ...), when the plugin version and the types version get out of sync. Adding the endpoint back with a note should prevent these problems and provide a better DX

@wolfy1339
Copy link
Member

The copilot endpoints are in beta, and are subject to change. I don't see this endpoint anywhere in the docs

@gr2m
Copy link
Contributor

gr2m commented May 15, 2024

@kfcampbell can you find out what the status is with the endpoint? If we can expect it to be re-released soon again, I'd vote for not removing it temporarily

@kfcampbell
Copy link
Member

I'm sorry, this slipped through the cracks for me. I've asked and will report back when I hear anything.

@kfcampbell
Copy link
Member

It was intended to be a temporary decision to unship the endpoint; it will be added back in the near future. We should probably not remove it across all our repos at this point.

@nickfloyd nickfloyd added the Status: Blocked Some technical or requirement is blocking the issue label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Blocked Some technical or requirement is blocking the issue Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Status: 🛑 Blocked/Awaiting Response
Development

Successfully merging this pull request may close these issues.

5 participants