Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: stop testing against NodeJS v14, v16 #78

Merged
merged 7 commits into from
Jun 12, 2023
Merged

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented May 13, 2023

BREAKING CHANGE: Drop support for NodeJS v14, v16

@wolfy1339 wolfy1339 added Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels May 13, 2023
@ghost ghost added this to Inbox in JS May 13, 2023
@ghost ghost moved this from Inbox to Maintenance in JS May 13, 2023
@wolfy1339 wolfy1339 changed the title ci: stop testing against NodeJS v14 ci: stop testing against NodeJS v14, v16 May 14, 2023
kfcampbell
kfcampbell previously approved these changes May 19, 2023
@kfcampbell
Copy link
Member

I've modified the branch protection rules on this repo to not require testing against Node 14 and 16. Please let me know if you'd like me to make further changes!

@nickfloyd
Copy link
Contributor

@kfcampbell kfcampbell merged commit bae565b into beta Jun 12, 2023
7 checks passed
@kfcampbell kfcampbell deleted the remove-eol-node-versions branch June 12, 2023 22:23
@github-actions
Copy link

🎉 This PR is included in version 3.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

kfcampbell added a commit that referenced this pull request Jun 28, 2023
* ci: stop testing against NodeJS v14, v16 (#78)

* build(package): set minimal node version in engines field to v18
BREAKING CHANGE: Drop support for NodeJS v14, v16

* ci: stop testing against NodeJS v14, v16

* ci: stop testing against NodeJS v14, v16

* ci: stop testing against NodeJS v14, v16

* ci: stop testing against NodeJS v14, v16

* ci: stop testing against NodeJS v14, v16

* bumps @octokit/plugin-rest-endpoint-methods

---------

Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
Co-authored-by: Nick Floyd <139819+nickfloyd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @beta Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
JS
  
Maintenance
Development

Successfully merging this pull request may close these issues.

None yet

3 participants