-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: stop testing against NodeJS v14, v16 #152
Conversation
1927b28
to
dbbb39a
Compare
BREAKING CHANGE: Drop support for NodeJS v14, v16
dbbb39a
to
b5b842c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wolfy1339 is there anything else you'd like to see done before I merge this PR (and similar PRs you've opened in the past)?
Not all of theses PRs can be merged. Current beta versions of modules won't affect this module, so this one can be safely merged |
If a plugin handles routes, or requests, or a plugin extending requests, it will have to wait until the changes for the next major version are complete |
Basically, anything that might get affected by the work to remove previews for the REST API |
Hmm...could you help me maybe make a complete list? My best guess is: But I'm pretty confident I didn't split them correctly. |
The ones that are listed in the "Merge to Beta" column need to wait for updates from upstream packages to trickle down before they can be merged to stable, as those packages have some breaking changes waiting. If there is already a |
Thanks @wolfy1339! I'll go through and knock these out. |
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: Drop support for NodeJS v14, v16