Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: stop testing against NodeJS v14, v16 #152

Merged
merged 11 commits into from
Jun 12, 2023
Merged

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented May 13, 2023

BREAKING CHANGE: Drop support for NodeJS v14, v16

@wolfy1339 wolfy1339 added Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels May 13, 2023
@wolfy1339 wolfy1339 changed the title ci: stop testing against NodeJS v14 ci: stop testing against NodeJS v14, v16 May 14, 2023
kfcampbell
kfcampbell previously approved these changes May 19, 2023
@nickfloyd
Copy link
Contributor

kfcampbell
kfcampbell previously approved these changes Jun 9, 2023
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolfy1339 is there anything else you'd like to see done before I merge this PR (and similar PRs you've opened in the past)?

@wolfy1339
Copy link
Member Author

Not all of theses PRs can be merged. Current beta versions of modules won't affect this module, so this one can be safely merged

@kfcampbell
Copy link
Member

How are you determining which PRs can/cannot be merged? My tentative plan was go to through the list in "In Review" here and do the merges in that order, which @gr2m organized (thank you!) in an order that will minimize dependency hassles.

@wolfy1339
Copy link
Member Author

If a plugin handles routes, or requests, or a plugin extending requests, it will have to wait until the changes for the next major version are complete

@wolfy1339
Copy link
Member Author

Basically, anything that might get affected by the work to remove previews for the REST API

@wolfy1339
Copy link
Member Author

wolfy1339 commented Jun 9, 2023

Merge to Beta Okay to Merge
octokit/plugin-rest-endpoint-methods.js#637 #152
octokit/plugin-paginate-graphql.js#78 octokit/webhooks-methods.js#157
octokit/auth-callback.js#148
octokit/auth-unauthenticated.js#219
octokit/auth-token.js#340
octokit/auth-action.js#313
octokit/auth-oauth-app.js#337
octokit/auth-oauth-device.js#143
octokit/auth-oauth-user.js#155
octokit/auth-app.js#477
octokit/webhooks.js#849
octokit/create-octokit-project.js#257
octokit/plugin-enterprise-cloud.js#437
octokit/plugin-enterprise-server.js#564
octokit/plugin-request-log.js#321

The ones that are listed in the "Merge to Beta" column need to wait for updates from upstream packages to trickle down before they can be merged to stable, as those packages have some breaking changes waiting.

If there is already a beta branch with an open PR, merge it there and not main

@kfcampbell
Copy link
Member

Thanks @wolfy1339! I'll go through and knock these out.

@kfcampbell kfcampbell dismissed their stale review June 12, 2023 19:00

The merge-base changed after approval.

@kfcampbell kfcampbell merged commit b351e41 into main Jun 12, 2023
@kfcampbell kfcampbell deleted the remove-eol-node-versions branch June 12, 2023 19:04
@github-actions
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants