Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json is missing node-fetch dependency #14

Closed
LucianBuzzo opened this issue Nov 22, 2018 · 2 comments
Closed

package.json is missing node-fetch dependency #14

LucianBuzzo opened this issue Nov 22, 2018 · 2 comments

Comments

@LucianBuzzo
Copy link
Contributor

This file https://github.com/octokit/request.js/blob/master/lib/fetch.js requires node-fetch, but it is not listed as a dependency in package.json
@LucianBuzzo
Copy link
Contributor Author

Presumably the version needed is v2.1.1 looking at the octokit/rest.js package https://github.com/octokit/rest.js/blob/master/package.json#L43

@LucianBuzzo LucianBuzzo mentioned this issue Nov 22, 2018
Merged
@gr2m gr2m closed this as completed in #15 Nov 22, 2018
gr2m pushed a commit that referenced this issue Nov 22, 2018
@LucianBuzzo @gr2m
fix: add missing node-fetch dependency
630416b 
Fixes #14

Signed-off-by: Lucian <lucian.buzzo@gmail.com>
@octokitbot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LucianBuzzo @octokitbot