-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass on to the next middleware in case of express #534
Conversation
As I explained [here](octokit#509 (comment)), it is now required to always install this middleware to the end of the chain, otherwise it rejects all requests it cannot handle.
@gr2m PTAL and help me understand whether this is a valid change. Thanks a lot. |
Sorry I couldn't figure out how to add a correct label. I guess this is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you @honnix 👍🏼 I'm not very familiar with express, if there is anything we can do to make it easier to use for express users, please let us know.
I also made follow up issue to make sure we test the express integration in @octokit/oauth-app
and @octokit/app
: octokit/app.js#236, octokit/oauth-app.js#222
🎉 This PR is included in version 9.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@gr2m Thanks for approving and merging. I cannot say myself familiar with express either but I thinkthe added test cases should help catch similar problem in the future. |
As I explained here, it is now required to always install this middleware to the end of the chain, otherwise it rejects all requests it cannot handle.