Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support X-Features #10

Closed
4 tasks
kamilsk opened this issue Nov 15, 2020 · 2 comments
Closed
4 tasks

support X-Features #10

kamilsk opened this issue Nov 15, 2020 · 2 comments
Assignees
@kamilsk
Labels
difficulty: medium help wanted Extra attention is needed

Comments

@kamilsk
Copy link
Member

kamilsk commented Nov 15, 2020

  • add specific header
req.Header.Set(http.XFeatures, config.Feature{Name, false}.String())
  • extend config module
features.Find -> alias for FindByName

config.Features.Unmarshal(req.Header.Get(http.XFeatures)).Find(needs)
  • context support
ctx = context.WithValue(req.Context, Features, MutatedFeatures)
  • timeout/deadline support
context.Value(Features).Find(Deadline).Enabled -> apply middleware
@kamilsk kamilsk added help wanted Extra attention is needed difficulty: medium labels Nov 15, 2020
@kamilsk kamilsk self-assigned this Nov 15, 2020
@kamilsk
Copy link
Member Author

kamilsk commented Nov 15, 2020

blocked by octolab/config#4

@kamilsk
Copy link
Member Author

kamilsk commented Jan 10, 2021

moved to octolab/propaganda#4

@kamilsk kamilsk closed this as completed Jan 10, 2021
@kamilsk kamilsk mentioned this issue May 14, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilsk kamilsk

Labels
difficulty: medium help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kamilsk