Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Ghost Ship to use a lot of stuff from octopusthink.com #24

Merged
merged 4 commits into from
Dec 18, 2019

Conversation

tofumatt
Copy link
Member

@tofumatt tofumatt commented Dec 18, 2019

This is a major refactoring of Ghost Ship. It brings in a lot of stuff we've learned from octopusthink.com, but it also allows the Blog and Portfolio sections of the website to be entirely optional. They can be removed by deleting the relevant folders—restoring the folders will actually restore the functionality. But no other config need be done.

In the future it'd be nice if you could "restore" the blog/portfolio functionality with an npm run add:blog functionality. For now, you can remove them that way (eg. npm run remove:blog).

It's a start. This'll be a beast to review and it's largely just ported and optimised stuff from https://github.com/octopusthink/octopusthink.com/

If you want to look through it feel free, but if you want to just merge it I've got no issues with that. It seems to work well! 😄


Copy link
Member

@sarahmonster sarahmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm down with merging this and then making any additional changes iteratively.

FYI #3 and #19 both warrant some more work before being closed, so I'd say this more part-fixes them than fully-fixes them! I might look into that SEO junk this evening though, since it's been on my list a while now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants