Skip to content

Commit

Permalink
Fix duplication in development docker-compose file.
Browse files Browse the repository at this point in the history
  • Loading branch information
jsthomas committed Jul 29, 2021
1 parent dbfeae7 commit c07b17b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
7 changes: 7 additions & 0 deletions HACKING.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ Edit the `./environments/development.env` file and adjust the configurations var

Make sure that the `./environments/development.env` exists and has the correct configuration.

Before you start your docker containers for the first time, you'll
need to create an external docker volume, like this:

```
docker volume create --name=current-bench-data
```

Start the docker-compose environment:

```
Expand Down
10 changes: 1 addition & 9 deletions environments/development.docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,10 @@ services:
args:
TARGET_ARCH: ${OCAML_BENCH_TARGET_ARCH?required}
volumes:
- current-bench-data:/app/current-bench-data
# Mount the source code of the test project to allow local testing.
- current-bench-data:/app/current-bench-data
- ../local-test-repo:/app/local-test-repo
- /var/run/docker.sock:/var/run/docker.sock
ports:
[
"${OCAML_BENCH_PIPELINE_PORT?required}:${OCAML_BENCH_PIPELINE_PORT?required}",
]
# Mount the source code of the test project to allow local testing.
- current-bench-data:/app/current-bench-data:ro
- ../local-test-repo:/app/local-test-repo
- /var/run/docker.sock:/var/run/docker.sock
ports: ["${OCAML_BENCH_PIPELINE_PORT?required}:${OCAML_BENCH_PIPELINE_PORT?required}"]
command:
- "current-bench-pipeline"
Expand Down

0 comments on commit c07b17b

Please sign in to comment.