prod_name in get_par_by_name

[dsavchenko]

No description provided.

[volodymyrss]

it seems to make sense, but could you please explain a little bit the motivation?

[dsavchenko]

it seems to make sense, but could you please explain a little bit the motivation?

I came up with this in the context of oda-hub/dispatcher-plugin-nb2workflow#47. When I build a request to the backend, I want to be sure that the parameter I'm working with is coming from the proper product. If parameters with the same name are annotated differently in the notebooks, they are not equivalent in the dispatcher. It addresses the TODO comment

dispatcher-app/cdci_data_analysis/analysis/instrument.py

Line 524 in 439af5d

# TODO: this picks the last one if there are many?..

for this case.

It's not a strictly necessary change, I guess, as the problem in oda-hub/dispatcher-plugin-nb2workflow#47 concerns SourceQuery parameters, but it's cleaner to use it this way

[codecov]

Codecov Report

Merging #537 (5a26718) into master (fe7aaf5) will increase coverage by 0.04%.
The diff coverage is 76.66%.

@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
+ Coverage   62.27%   62.32%   +0.04%     
==========================================
  Files          45       45              
  Lines        7606     7620      +14     
==========================================
+ Hits         4737     4749      +12     
- Misses       2869     2871       +2     

Impacted Files	Coverage Δ
cdci_data_analysis/analysis/instrument.py	81.41% <68.42%> (-0.07%)	⬇️
cdci_data_analysis/analysis/queries.py	61.35% <90.90%> (+0.54%)	⬆️

[volodymyrss]

something breaks though

[volodymyrss]

oh, do we already have test for this? could you add one?

[burnout87]

Very useful thanks.

EDIT: also a dedicated test would be really useful, something was already done here:

dispatcher-app/tests/test_parameters.py

Line 34 in fe7aaf5

def test_repeating_parameters(add_duplicate):

[dsavchenko]

could you merge please?

[volodymyrss]

I add you to maintainers, I think you add enough code. I merge though