Unit tests

[volodymyrss]

No description provided.

[volodymyrss]

this will need oda-hub/dispatcher-app#69

[volodymyrss]

Note that the one more "real" test successfully fails at the moment. I did not attempt understading what a meaningful request would be. But I was amused by the sort of error message it returns, maybe it points to another bug, maybe even in dispatcher.

We also discussed with @burnout87 that similar approach can be adopted for other plugins

[burnout87]

I think this is the approach to follow, also for the other plugins

[burnout87]

Minor: perhaps also 'config' will have to be inserted in the vocab list

[burnout87]

I might got confused, what are the two keys to edit?

[dsavchenko]

Note that the one more "real" test successfully fails at the moment.

Of course, as to process real query it relies on backend.

But I was amused by the sort of error message it returns, maybe it points to another bug, maybe even in dispatcher.

Not in the dispatcher. I even put a comment and then forgot about it

dispatcher-plugin-antares/dispatcher_plugin_antares/antares_dataserver_dispatcher.py

Line 217 in fcb60bb

excep=e, # may be referenced before assignment

[volodymyrss]

Note that the one more "real" test successfully fails at the moment.

Of course, as to process real query it relies on backend.

Alright! Could be there is some meaningful dummy-like query?
Or you could install it as a requirement and test it with a another fixture. If it is possible.

If not, the test should be really considered an "integration", in sense that it will be run on a specific instance, deployed for review.
I.e. it will not work with github actions.
In this case, the backend access will be configured on defining the test.
You can test it while setting your own instance.
And we test it after deploying in unige and also regularly.

But I was amused by the sort of error message it returns, maybe it points to another bug, maybe even in dispatcher.

Not in the dispatcher. I even put a comment and then forgot about it

dispatcher-plugin-antares/dispatcher_plugin_antares/antares_dataserver_dispatcher.py

Line 217 in fcb60bb

excep=e, # may be referenced before assignment

ok! It's really a kind of feature common in the dispatcher through. So see as you

[dsavchenko]

Ideologically it will look more like an integration test

without backend it will fail unless query_type='Dummy' (which itself is the desirable behaviour, which could be tested in units)

For query_type='Dummy' it should inherit the proper dummy behaviour from the base classes defined in dispatcher, no need to implement something specific. Am I right?

[dsavchenko]

@andriineronov should I put here Paris? APC or IPGP or something?

[andriineronov]

Just skip "CDCI"

[dsavchenko]

@andriineronov I am about this line

[ferrigno]

Remove "ISDC Data Centre for Astrophysics," it does not exist

[volodymyrss]

we could really also do these changes in a separate PR, it's not very clear if we are ok with the changes suggested here.

[dsavchenko]

For query_type='Dummy' it should inherit the proper dummy behaviour from the base classes defined in the dispatcher, no need to implement something specific. Am I right?

I am not fully right. I got: get_dummy_products needs to be implemented in derived class.

So let's stick with what is here as a baseline. Then I will implement this method and use Dummy query in test

[volodymyrss]

For query_type='Dummy' it should inherit the proper dummy behaviour from the base classes defined in the dispatcher, no need to implement something specific. Am I right?

I am not fully right. I got: get_dummy_products needs to be implemented in derived class.

So let's stick with what is here as a baseline. Then I will implement this method and use Dummy query in test

you are very right though that it's good to stick with the baseline and separate other details features to elsewhere!