Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reusable fixture, for reuse in plugins and api #69

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Reusable fixture, for reuse in plugins and api #69

merged 2 commits into from
Apr 28, 2021

Conversation

volodymyrss
Copy link
Member

No description provided.

@volodymyrss volodymyrss mentioned this pull request Apr 27, 2021
Merged
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #69 (fc34699) into master (edef0f6) will increase coverage by 1.86%.
The diff coverage is 78.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   25.36%   27.22%   +1.86%     
==========================================
  Files          32       33       +1     
  Lines        4002     4147     +145     
==========================================
+ Hits         1015     1129     +114     
- Misses       2987     3018      +31
Impacted Files Coverage Δ
cdci_data_analysis/pytest_fixtures.py 78.62% <78.62%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edef0f6...fc34699. Read the comment docs.

burnout87
burnout87 reviewed Apr 28, 2021
View reviewed changes
Copy link
Collaborator

@burnout87 burnout87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this approach completely replace the 'tests/test-conf.yaml' file?

cdci_data_analysis/pytest_fixtures.py
email_sending_timeout_default_threshold: 1800
email_sending_job_submitted: True
""")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this, don't you end up writing within the 'test-dispatcher-conf.yaml' file the same content?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. but it's easier to do like this that to distribute and then discover yet another non-code file. see how discovery of the test*yaml was rather cumbersome

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it will just have to be aligned with the latest version of the configuration

@volodymyrss
Copy link
Member Author

Will this approach completely replace the 'tests/test-conf.yaml' file?

yes

@volodymyrss volodymyrss merged commit a3acc8b into master Apr 28, 2021
@volodymyrss volodymyrss deleted the reusable-fixture branch April 28, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burnout87 burnout87 burnout87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volodymyrss @burnout87