update-oddcontrast #519
Merged
update-oddcontrast #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..update-oddcontrast |
SondraE
requested review from
jgerigmeyer,
stacyk and
jamesnw
and removed request for
stacyk
3 tasks
jamesnw
approved these changes
Feb 20, 2024
jgerigmeyer
reviewed
Feb 20, 2024
README.md
Outdated
Comment on lines
25
to
27
| be used automatically for any `yarn` command. To activate it, run | ||
| `corepack enable` | ||
| (once per local Node installation). |
There was a problem hiding this comment.
@SondraE Out of curiosity, why this change?
There was a problem hiding this comment.
@jgerigmeyer There was a line break between corepack and enable that meant the corepack enable command wasn't highlighted. Because it wasn't highlighted, I missed it. I asked James why I was getting errors, and he directed me to it.
There was a problem hiding this comment.
Oh, in your local editor? That makes sense. Wrapping doesn't impact highlighting on GitHub: https://github.com/oddbird/oddleventy#install-node-and-yarn
jgerigmeyer
approved these changes
Feb 20, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to test/reproduce