-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A layout post #621
A layout post #621
Conversation
View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..wkshp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Learn CSS Grid, Seriously subtitle should probably be Learn CSS grid, seriously to match the other subtitles.
Can you add a blurb about the CSS Workshop just like you did in the last article you release?
Otherwise, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, really puts things into a priority order for those who have "things to learn" list
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: david herron <41588129+dvdherron@users.noreply.github.com>
Co-authored-by: Jonny Gerig Meyer <jonny@oddbird.net>
Co-authored-by: Stacy Kvernmo <stacyk@users.noreply.github.com>
@SondraE @stacyk @jgerigmeyer - I added the workshop mentions, and a couple other bits of info. Let me know if you see issues, or feel free to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: Great way to put things into perspective. Small nit on the consistency of the capitalization of grid.
Co-authored-by: david herron <41588129+dvdherron@users.noreply.github.com>
There's probably no good reason to capitalize outside the names of specification modules? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our styleguide, we do say to write headings in Title Case, but I'm not sure we do that consistently
content/blog/2024/css-layout.md
Outdated
(If you want to learn more, | ||
check out our workshop below) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need parentheses here? Also, I'd add the .
at the end.
@stacyk shoot, I'm really bad at title case. Do my proposed changes look right? Why is the mixin article showing up as new in this PR? |
we were just talking about the sace during standup now. We decided post titles should be titlecase, and as long as the casing is consistent within the post for headings, then that's fine. I also thought it was strange to see the mixin article here. I didn't look into it though. |
* main: Update content/workshops/cascading-layouts.md Add registration fallback link Add summary Workshop pitch Add blender image Roma -> Roman Update content/blog/2024/removing-mixins.md off-switch -> off switch Apply suggestions from code review Apply suggestions from code review Blog post on un-mixing a mixin
@stacyk ok, I think it's all fixed! |
Description
Uncomment if you want to provide a custom description.
This needs an image, and some workshop marketing.
Related Issue(s)
Reminder to add related issue(s), if available.