Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A layout post #621

Merged
merged 18 commits into from
Jun 13, 2024
Merged

A layout post #621

merged 18 commits into from
Jun 13, 2024

Conversation

mirisuzanne
Copy link
Member

Description

Uncomment if you want to provide a custom description.

This needs an image, and some workshop marketing.

Related Issue(s)

Reminder to add related issue(s), if available.

Copy link

View diff of compiled files (may take a few minutes): https://github.com/oddbird/oddleventy-built/compare/main..wkshp

content/blog/2024/css-layout.md Outdated Show resolved Hide resolved
content/blog/2024/css-layout.md Outdated Show resolved Hide resolved
content/blog/2024/css-layout.md Outdated Show resolved Hide resolved
content/blog/2024/css-layout.md Outdated Show resolved Hide resolved
Copy link
Contributor

@SondraE SondraE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Learn CSS Grid, Seriously subtitle should probably be Learn CSS grid, seriously to match the other subtitles.

Can you add a blurb about the CSS Workshop just like you did in the last article you release?

Otherwise, LGTM

Copy link
Member

@stacyk stacyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, really puts things into a priority order for those who have "things to learn" list

content/blog/2024/css-layout.md Outdated Show resolved Hide resolved
mirisuzanne and others added 12 commits June 12, 2024 15:41
@mirisuzanne
Copy link
Member Author

@SondraE @stacyk @jgerigmeyer - I added the workshop mentions, and a couple other bits of info. Let me know if you see issues, or feel free to merge.

Copy link
Contributor

@dvdherron dvdherron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Great way to put things into perspective. Small nit on the consistency of the capitalization of grid.

content/blog/2024/css-layout.md Outdated Show resolved Hide resolved
Co-authored-by: david herron <41588129+dvdherron@users.noreply.github.com>
@mirisuzanne
Copy link
Member Author

Small nit on the consistency of the capitalization of grid.

There's probably no good reason to capitalize outside the names of specification modules?

Copy link
Member

@stacyk stacyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our styleguide, we do say to write headings in Title Case, but I'm not sure we do that consistently

Comment on lines 285 to 286
(If you want to learn more,
check out our workshop below)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need parentheses here? Also, I'd add the . at the end.

@mirisuzanne
Copy link
Member Author

@stacyk shoot, I'm really bad at title case. Do my proposed changes look right?

Why is the mixin article showing up as new in this PR?

@stacyk
Copy link
Member

stacyk commented Jun 13, 2024

@stacyk shoot, I'm really bad at title case. Do my proposed changes look right?

Why is the mixin article showing up as new in this PR?

we were just talking about the sace during standup now. We decided post titles should be titlecase, and as long as the casing is consistent within the post for headings, then that's fine.

I also thought it was strange to see the mixin article here. I didn't look into it though.

* main:
  Update content/workshops/cascading-layouts.md
  Add registration fallback link
  Add summary
  Workshop pitch
  Add blender image
  Roma -> Roman
  Update content/blog/2024/removing-mixins.md
  off-switch -> off switch
  Apply suggestions from code review
  Apply suggestions from code review
  Blog post on un-mixing a mixin
@mirisuzanne
Copy link
Member Author

@stacyk ok, I think it's all fixed!

@mirisuzanne mirisuzanne merged commit 2019f80 into main Jun 13, 2024
10 checks passed
@mirisuzanne mirisuzanne deleted the wkshp branch June 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants